Commit 81455e72211e41972cca1d4686bc07b2e93b81e1

Authored by Julia Lawall
Committed by Rafael J. Wysocki
1 parent f1618a7a27

cpuidle-kirkwood.c: simplify use of devm_ioremap_resource()

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to
devm_ioremap_resource().

A simplified version of the semantic patch that makes this change is
as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Showing 1 changed file with 0 additions and 3 deletions Side-by-side Diff

drivers/cpuidle/cpuidle-kirkwood.c
... ... @@ -60,9 +60,6 @@
60 60 struct resource *res;
61 61  
62 62 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
63   - if (res == NULL)
64   - return -EINVAL;
65   -
66 63 ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
67 64 if (IS_ERR(ddr_operation_base))
68 65 return PTR_ERR(ddr_operation_base);