nfsd4: make sure set CB_PATH_DOWN sequence flag set

Make sure this is set whenever there is no callback channel. If a client does not set up a callback channel at all, then it will get this flag set from the very start. That's OK, it can just ignore the flag if it doesn't care. If a client does care, I think it's better to inform it of the problem as early as possible. Reported-by: Rick Macklem <rmacklem@uoguelph.ca> Signed-off-by: J. Bruce Fields <bfields@redhat.com>

nfsd4: make sure set CB_PATH_DOWN sequence flag set
Make sure this is set whenever there is no callback channel. If a client does not set up a callback channel at all, then it will get this flag set from the very start. That's OK, it can just ignore the flag if it doesn't care. If a client does care, I think it's better to inform it of the problem as early as possible. Reported-by: Rick Macklem <rmacklem@uoguelph.ca> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
J. Bruce Fields
1 parent 59deeb9e5a
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
fs/nfsd/nfs4callback.c
@@ -986,7 +986,7 @@
  
 	err = setup_callback_client(clp, &conn, ses);
 	if (err) {
-		warn_no_callback_path(clp, err);
+		nfsd4_mark_cb_down(clp, err);
 		return;
 	}
 	/* Yay, the callback channel's back! Restart any callbacks: */
...	...	@@ -986,7 +986,7 @@
986	986
987	987	err = setup_callback_client(clp, &conn, ses);
988	988	if (err) {
989		- warn_no_callback_path(clp, err);
	989	+ nfsd4_mark_cb_down(clp, err);
990	990	return;
991	991	}
992	992	/* Yay, the callback channel's back! Restart any callbacks: */