Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit 88dacbe961aa63fa880b4f6f16515427f61fc3ca

Authored by Willy Tarreau
Committed by Adrian Bunk
1 parent 8a03d9a498

rio: typo in bitwise AND expression. 

The line :

    hp->Mode &= !RIO_PCI_INT_ENABLE;

is obviously wrong as RIO_PCI_INT_ENABLE=0x04 and is used as a bitmask
2 lines before. Getting no IRQ would not disable RIO_PCI_INT_ENABLE
but rather RIO_PCI_BOOT_FROM_RAM which equals 0x01.

Obvious fix is to change ! for ~.

Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Adrian Bunk <bunk@stusta.de>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/char/rio/rio_linux.c
Diff comments   View file @ 88dacbe
... ... @@ -1146,7 +1146,7 @@
1146 1146 rio_dprintk(RIO_DEBUG_INIT, "Enabling interrupts on rio card.\n");
1147 1147 hp->Mode |= RIO_PCI_INT_ENABLE;
1148 1148 } else
1149   - hp->Mode &= !RIO_PCI_INT_ENABLE;
  1149 + hp->Mode &= ~RIO_PCI_INT_ENABLE;
1150 1150 rio_dprintk(RIO_DEBUG_INIT, "New Mode: %x\n", hp->Mode);
1151 1151 rio_start_card_running(hp);
1152 1152 }