Commit 90cce03d9bfcb28600a56efef6b0a5a4fbf6c2b1
Committed by
Linus Torvalds
1 parent
b8a124da92
Exists in
master
and in
20 other branches
wait_for_helper: remove unneeded do_sigaction()
allow_signal(SIGCHLD) does all necessary job, no need to call do_sigaction() prior to. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Showing 1 changed file with 0 additions and 5 deletions Side-by-side Diff
kernel/kmod.c
... | ... | @@ -185,14 +185,9 @@ |
185 | 185 | { |
186 | 186 | struct subprocess_info *sub_info = data; |
187 | 187 | pid_t pid; |
188 | - struct k_sigaction sa; | |
189 | 188 | |
190 | 189 | /* Install a handler: if SIGCLD isn't handled sys_wait4 won't |
191 | 190 | * populate the status, but will return -ECHILD. */ |
192 | - sa.sa.sa_handler = SIG_IGN; | |
193 | - sa.sa.sa_flags = 0; | |
194 | - siginitset(&sa.sa.sa_mask, sigmask(SIGCHLD)); | |
195 | - do_sigaction(SIGCHLD, &sa, NULL); | |
196 | 191 | allow_signal(SIGCHLD); |
197 | 192 | |
198 | 193 | pid = kernel_thread(____call_usermodehelper, sub_info, SIGCHLD); |