Commit 91ae1220790f101d55b4318fdb6c80cb3840745f

Authored by Radim Krčmář
Committed by Greg Kroah-Hartman
1 parent 856d760ca0

hv: use correct order when freeing monitor_pages

commit a100d88df1e924e5c9678fabf054d1bae7ab74fb upstream.

We try to free two pages when only one has been allocated.
Cleanup path is unlikely, so I haven't found any trace that would fit,
but I hope that free_pages_prepare() does catch it.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Reviewed-by: Amos Kong <akong@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

drivers/hv/connection.c
... ... @@ -224,8 +224,8 @@
224 224 vmbus_connection.int_page = NULL;
225 225 }
226 226  
227   - free_pages((unsigned long)vmbus_connection.monitor_pages[0], 1);
228   - free_pages((unsigned long)vmbus_connection.monitor_pages[1], 1);
  227 + free_pages((unsigned long)vmbus_connection.monitor_pages[0], 0);
  228 + free_pages((unsigned long)vmbus_connection.monitor_pages[1], 0);
229 229 vmbus_connection.monitor_pages[0] = NULL;
230 230 vmbus_connection.monitor_pages[1] = NULL;
231 231