Commit 9212ddb5eada64fec5a08b28207401f3cc3d0876

Authored by Ingo Molnar
1 parent 4a6908a3a0

stacktrace: provide save_stack_trace_tsk() weak alias

Impact: build fix

Some architectures have not implemented save_stack_trace_tsk() yet:

  fs/built-in.o: In function `proc_pid_stack':
  base.c:(.text+0x3f140): undefined reference to `save_stack_trace_tsk'

So warn about that if the facility is used.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

Showing 1 changed file with 11 additions and 0 deletions Side-by-side Diff

... ... @@ -6,6 +6,7 @@
6 6 * Copyright (C) 2006 Red Hat, Inc., Ingo Molnar <mingo@redhat.com>
7 7 */
8 8 #include <linux/sched.h>
  9 +#include <linux/kernel.h>
9 10 #include <linux/module.h>
10 11 #include <linux/kallsyms.h>
11 12 #include <linux/stacktrace.h>
... ... @@ -23,4 +24,15 @@
23 24 }
24 25 }
25 26 EXPORT_SYMBOL_GPL(print_stack_trace);
  27 +
  28 +/*
  29 + * Architectures that do not implement save_stack_trace_tsk get this
  30 + * weak alias and a once-per-bootup warning (whenever this facility
  31 + * is utilized - for example by procfs):
  32 + */
  33 +__weak void
  34 +save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
  35 +{
  36 + WARN_ONCE(1, KERN_INFO "save_stack_trace_tsk() not implemented yet.\n");
  37 +}