Commit 948409c74d217f6cf054b8c927765a1c3fe16b53
Committed by
root
root
1 parent
d124b60a83
Exists in
master
and in
20 other branches
vfs: add a comment to inode_permission()
Acked-by: J. Bruce Fields <bfields@redhat.com> Acked-by: David Howells <dhowells@redhat.com> Signed-off-by: Andreas Gruenbacher <agruen@kernel.org> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Showing 1 changed file with 4 additions and 2 deletions Side-by-side Diff
fs/namei.c
| ... | ... | @@ -221,7 +221,7 @@ |
| 221 | 221 | } |
| 222 | 222 | |
| 223 | 223 | /* |
| 224 | - * This does basic POSIX ACL permission checking | |
| 224 | + * This does the basic permission checking | |
| 225 | 225 | */ |
| 226 | 226 | static int acl_permission_check(struct inode *inode, int mask) |
| 227 | 227 | { |
| ... | ... | @@ -271,7 +271,7 @@ |
| 271 | 271 | int ret; |
| 272 | 272 | |
| 273 | 273 | /* |
| 274 | - * Do the basic POSIX ACL permission checks. | |
| 274 | + * Do the basic permission checks. | |
| 275 | 275 | */ |
| 276 | 276 | ret = acl_permission_check(inode, mask); |
| 277 | 277 | if (ret != -EACCES) |
| ... | ... | @@ -335,6 +335,8 @@ |
| 335 | 335 | * We use "fsuid" for this, letting us set arbitrary permissions |
| 336 | 336 | * for filesystem access without changing the "normal" uids which |
| 337 | 337 | * are used for other things. |
| 338 | + * | |
| 339 | + * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask. | |
| 338 | 340 | */ |
| 339 | 341 | int inode_permission(struct inode *inode, int mask) |
| 340 | 342 | { |