Commit 9fd93784f1719532d796914935f87cc1c6afd687
1 parent
9ee984a5f7
Exists in
master
and in
13 other branches
drm: remove return value from drm_helper_mode_fill_fb_struct
Rightfully no driver ever checked this - it can't fail. Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Showing 2 changed files with 4 additions and 6 deletions Side-by-side Diff
drivers/gpu/drm/drm_crtc_helper.c
| ... | ... | @@ -923,8 +923,8 @@ |
| 923 | 923 | } |
| 924 | 924 | EXPORT_SYMBOL(drm_helper_connector_dpms); |
| 925 | 925 | |
| 926 | -int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb, | |
| 927 | - struct drm_mode_fb_cmd2 *mode_cmd) | |
| 926 | +void drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb, | |
| 927 | + struct drm_mode_fb_cmd2 *mode_cmd) | |
| 928 | 928 | { |
| 929 | 929 | int i; |
| 930 | 930 | |
| ... | ... | @@ -937,8 +937,6 @@ |
| 937 | 937 | drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth, |
| 938 | 938 | &fb->bits_per_pixel); |
| 939 | 939 | fb->pixel_format = mode_cmd->pixel_format; |
| 940 | - | |
| 941 | - return 0; | |
| 942 | 940 | } |
| 943 | 941 | EXPORT_SYMBOL(drm_helper_mode_fill_fb_struct); |
| 944 | 942 |
include/drm/drm_crtc_helper.h
| ... | ... | @@ -139,8 +139,8 @@ |
| 139 | 139 | |
| 140 | 140 | extern void drm_helper_move_panel_connectors_to_head(struct drm_device *); |
| 141 | 141 | |
| 142 | -extern int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb, | |
| 143 | - struct drm_mode_fb_cmd2 *mode_cmd); | |
| 142 | +extern void drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb, | |
| 143 | + struct drm_mode_fb_cmd2 *mode_cmd); | |
| 144 | 144 | |
| 145 | 145 | static inline void drm_crtc_helper_add(struct drm_crtc *crtc, |
| 146 | 146 | const struct drm_crtc_helper_funcs *funcs) |