Eric Lee / smarc-ti-linux-kernel | Embedian Git Server

Commit a0327ff0eda915be623658babacef706099c11a8

Authored by James Hogan 2013-01-25 18:13:59 +0800

Committed by Tejun Heo 2013-01-26 01:14:48 +0800

async: initialise list heads to fix crash

9fdb04cdc55 ("async: replace list of active domains with global list
of pending items") added a struct list_head global_list in struct
async_entry, which isn't initialised.  This means that if
!domain->registered at __async_schedule(), then list_del_init() will
be called on the list head in async_run_entry_fn with both pointers
NULL, causing a crash.  This is fixed by initialising both the
global_list and domain_list list_heads after kzalloc'ing the entry.

This was noticed due to dapm_power_widgets() which uses
ASYNC_DOMAIN_EXCLUSIVE, which initialises the domain->registered to 0.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: James Hogan <james.hogan@imgtec.com>
Reported-by: Stephen Warren <swarren@wwwdotorg.org>

Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff

kernel/async.c

kernel/async.c

Diff comments View file @ a0327ff

...	...	@@ -172,6 +172,8 @@
172	172	ptr(data, newcookie);
173	173	return newcookie;
174	174	}
	175	+ INIT_LIST_HEAD(&entry->domain_list);
	176	+ INIT_LIST_HEAD(&entry->global_list);
175	177	INIT_WORK(&entry->work, async_run_entry_fn);
176	178	entry->func = ptr;
177	179	entry->data = data;