Eric Lee / smarc-ti-linux-kernel | Embedian Git Server

Commit a9a315d41407cd1079eb815f4adae897cc08b0d2

Authored by Sachin Prabhu 2014-01-31 22:27:16 +0800

Committed by Steve French 2014-01-31 23:06:43 +0800

Exists in master and in 16 other branches

cifs: Fix check for regular file in couldbe_mf_symlink()

MF Symlinks are regular files containing content in a specified format.

The function couldbe_mf_symlink() checks the mode for a set S_IFREG bit
as a test to confirm that it is a regular file. This bit is also set for
other filetypes and simply checking for this bit being set may return
false positives.

We ensure that we are actually checking for a regular file by using the
S_ISREG macro to test instead.

Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reported-by: Neil Brown <neilb@suse.de>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <smfrench@gmail.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

fs/cifs/link.c

fs/cifs/link.c

Diff comments View file @ a9a315d

...	...	@@ -185,7 +185,7 @@
185	185	bool
186	186	couldbe_mf_symlink(const struct cifs_fattr *fattr)
187	187	{
188		- if (!(fattr->cf_mode & S_IFREG))
	188	+ if (!S_ISREG(fattr->cf_mode))
189	189	/* it's not a symlink */
190	190	return false;
191	191