Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit ab0e113f6bee71a3933755d2c9ae41fcee631800

Authored by Alex Thorlton
Committed by Linus Torvalds
1 parent a0715cc226
Exists in master and in 13 other branches dlt-processor-sdk-linux-03.00.00.04, processor-sdk-linux-02.00.01, smarc-ti-linux-3.15.y, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04, ti-linux-3.15.y, ti-lsk-linux-4.1.y

exec: kill the unnecessary mm->def_flags setting in load_elf_binary() 

load_elf_binary() sets current->mm->def_flags = def_flags and def_flags
is always zero.  Not only this looks strange, this is unnecessary
because mm_init() has already set ->def_flags = 0.

Signed-off-by: Alex Thorlton <athorlton@sgi.com>
Suggested-by: Oleg Nesterov <oleg@redhat.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Mel Gorman <mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 0 additions and 4 deletions Side-by-side Diff

... ... @@ -584,7 +584,6 @@
584 584 unsigned long start_code, end_code, start_data, end_data;
585 585 unsigned long reloc_func_desc __maybe_unused = 0;
586 586 int executable_stack = EXSTACK_DEFAULT;
587   - unsigned long def_flags = 0;
588 587 struct pt_regs *regs = current_pt_regs();
589 588 struct {
590 589 struct elfhdr elf_ex;
... ... @@ -723,9 +722,6 @@
723 722 retval = flush_old_exec(bprm);
724 723 if (retval)
725 724 goto out_free_dentry;
726   -
727   - /* OK, This is the point of no return */
728   - current->mm->def_flags = def_flags;
729 725  
730 726 /* Do this immediately, since STACK_TOP as used in setup_arg_pages
731 727 may depend on the personality. */