Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild

Pull misc non-critical kbuild changes from Michal Marek: - Fix for make TAGS - Fix for make rpm - Some new coccinelle semantic patches * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild: scripts/coccinelle: find constant additions that could be bit ors coccicheck: Allow to show the executed command line coccicheck: Allow the user to give a V= (verbose) argument scripts/coccinelle/misc/memcpy-assign.cocci: Replace memcpy with struct assignment kbuild: clear KBUILD_SRC when calling 'make' in RPM spec scripts/coccinelle/misc/semicolon.cocci: Add unneeded semicolon test scripts/tags.sh: Fix regex syntax for etags

Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild
Pull misc non-critical kbuild changes from Michal Marek: - Fix for make TAGS - Fix for make rpm - Some new coccinelle semantic patches * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild: scripts/coccinelle: find constant additions that could be bit ors coccicheck: Allow to show the executed command line coccicheck: Allow the user to give a V= (verbose) argument scripts/coccinelle/misc/memcpy-assign.cocci: Replace memcpy with struct assignment kbuild: clear KBUILD_SRC when calling 'make' in RPM spec scripts/coccinelle/misc/semicolon.cocci: Add unneeded semicolon test scripts/tags.sh: Fix regex syntax for etags
Linus Torvalds
2 parents 0ca7ffb356 24f0c2d6ff
Showing 7 changed files Side-by-side Diff
Documentation/coccinelle.txt
scripts/coccicheck
scripts/coccinelle/misc/memcpy-assign.cocci
scripts/coccinelle/misc/orplus.cocci
scripts/coccinelle/misc/semicolon.cocci
scripts/package/mkspec
scripts/tags.sh
@@ -87,6 +87,10 @@
 positives. Thus, reports must be carefully checked, and patches
 reviewed.
  
+To enable verbose messages set the V= variable, for example:
+
+   make coccicheck MODE=report V=1
+
  
  Using Coccinelle with a single semantic patch
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -2,6 +2,15 @@
  
 SPATCH="`which ${SPATCH:=spatch}`"
  
+# The verbosity may be set by the environmental parameter V=
+# as for example with 'make V=1 coccicheck'
+
+if [ -n "$V" -a "$V" != "0" ]; then
+	VERBOSE=1
+else
+	VERBOSE=0
+fi
+
 if [ "$C" = "1" -o "$C" = "2" ]; then
     ONLINE=1
  
@@ -46,6 +55,14 @@
     echo ''
 fi
  
+run_cmd() {
+	if [ $VERBOSE -ne 0 ] ; then
+		echo "Running: $@"
+	fi
+	eval $@
+}
+
+
 coccinelle () {
     COCCI="$1"
  
@@ -55,7 +72,7 @@
 #
 #    $SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null
  
-    if [ "$ONLINE" = "0" ] ; then
+    if [ $VERBOSE -ne 0 ] ; then
  
 	FILE=`echo $COCCI | sed "s|$srctree/||"`
  
  
  
@@ -91,15 +108,21 @@
     fi
  
     if [ "$MODE" = "chain" ] ; then
-	$SPATCH -D patch   $FLAGS -sp_file $COCCI $OPT $OPTIONS               || \
-	$SPATCH -D report  $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff || \
-	$SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS               || \
-	$SPATCH -D org     $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff || exit 1
+	run_cmd $SPATCH -D patch   \
+		$FLAGS -sp_file $COCCI $OPT $OPTIONS               || \
+	run_cmd $SPATCH -D report  \
+		$FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff || \
+	run_cmd $SPATCH -D context \
+		$FLAGS -sp_file $COCCI $OPT $OPTIONS               || \
+	run_cmd $SPATCH -D org     \
+		$FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff || exit 1
     elif [ "$MODE" = "rep+ctxt" ] ; then
-	$SPATCH -D report  $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff && \
-	$SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS || exit 1
+	run_cmd $SPATCH -D report  \
+		$FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff && \
+	run_cmd $SPATCH -D context \
+		$FLAGS -sp_file $COCCI $OPT $OPTIONS || exit 1
     else
-	$SPATCH -D $MODE   $FLAGS -sp_file $COCCI $OPT $OPTIONS || exit 1
+	run_cmd $SPATCH -D $MODE   $FLAGS -sp_file $COCCI $OPT $OPTIONS || exit 1
     fi
  
 }
+//
+// Replace memcpy with struct assignment.
+//
+// Confidence: High
+// Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments:
+// Options: --no-includes --include-headers
+
+virtual patch
+virtual report
+virtual context
+virtual org
+
+@r1 depends on !patch@
+identifier struct_name;
+struct struct_name to;
+struct struct_name from;
+struct struct_name *top;
+struct struct_name *fromp;
+position p;
+@@
+memcpy@p(\(&(to)\|top\), \(&(from)\|fromp\), \(sizeof(to)\|sizeof(from)\|sizeof(struct struct_name)\|sizeof(*top)\|sizeof(*fromp)\))
+
+@script:python depends on report@
+p << r1.p;
+@@
+coccilib.report.print_report(p[0],"Replace memcpy with struct assignment")
+
+@depends on context@
+position r1.p;
+@@
+*memcpy@p(...);
+
+@script:python depends on org@
+p << r1.p;
+@@
+cocci.print_main("Replace memcpy with struct assignment",p)
+
+@depends on patch@
+identifier struct_name;
+struct struct_name to;
+struct struct_name from;
+@@
+(
+-memcpy(&(to), &(from), sizeof(to));
++to = from;
+|
+-memcpy(&(to), &(from), sizeof(from));
++to = from;
+|
+-memcpy(&(to), &(from), sizeof(struct struct_name));
++to = from;
+)
+
+@depends on patch@
+identifier struct_name;
+struct struct_name to;
+struct struct_name *from;
+@@
+(
+-memcpy(&(to), from, sizeof(to));
++to = *from;
+|
+-memcpy(&(to), from, sizeof(*from));
++to = *from;
+|
+-memcpy(&(to), from, sizeof(struct struct_name));
++to = *from;
+)
+
+@depends on patch@
+identifier struct_name;
+struct struct_name *to;
+struct struct_name from;
+@@
+(
+-memcpy(to, &(from), sizeof(*to));
++ *to = from;
+|
+-memcpy(to, &(from), sizeof(from));
++ *to = from;
+|
+-memcpy(to, &(from), sizeof(struct struct_name));
++ *to = from;
+)
+
+@depends on patch@
+identifier struct_name;
+struct struct_name *to;
+struct struct_name *from;
+@@
+(
+-memcpy(to, from, sizeof(*to));
++ *to = *from;
+|
+-memcpy(to, from, sizeof(*from));
++ *to = *from;
+|
+-memcpy(to, from, sizeof(struct struct_name));
++ *to = *from;
+)
+/// Check for constants that are added but are used elsewhere as bitmasks
+/// The results should be checked manually to ensure that the nonzero
+/// bits in the two constants are actually disjoint.
+///
+// Confidence: Moderate
+// Copyright: (C) 2013 Julia Lawall, INRIA/LIP6.  GPLv2.
+// Copyright: (C) 2013 Gilles Muller, INRIA/LIP6.  GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments:
+// Options: -no_includes -include_headers
+
+virtual org
+virtual report
+virtual context
+
+@r@
+constant c;
+identifier i;
+expression e;
+@@
+
+(
+e | c@i
+|
+e & c@i
+|
+e |= c@i
+|
+e &= c@i
+)
+
+@s@
+constant r.c,c1;
+identifier i1;
+position p;
+@@
+
+(
+ c1 + c - 1
+|
+*c1@i1 +@p c
+)
+
+@script:python depends on org@
+p << s.p;
+@@
+
+cocci.print_main("sum of probable bitmasks, consider |",p)
+
+@script:python depends on report@
+p << s.p;
+@@
+
+msg = "WARNING: sum of probable bitmasks, consider |"
+coccilib.report.print_report(p[0],msg)
+///
+/// Removes unneeded semicolon.
+///
+// Confidence: Moderate
+// Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments: Some false positives on empty default cases in switch statements.
+// Options: --no-includes --include-headers
+
+virtual patch
+virtual report
+virtual context
+virtual org
+
+@r_default@
+position p;
+@@
+switch (...)
+{
+default: ...;@p
+}
+
+@r_case@
+position p;
+@@
+(
+switch (...)
+{
+case ...:;@p
+}
+|
+switch (...)
+{
+case ...:...
+case ...:;@p
+}
+|
+switch (...)
+{
+case ...:...
+case ...:
+case ...:;@p
+}
+)
+
+@r1@
+statement S;
+position p1;
+position p != {r_default.p, r_case.p};
+identifier label;
+@@
+(
+label:;
+|
+S@p1;@p
+)
+
+@script:python@
+p << r1.p;
+p1 << r1.p1;
+@@
+if p[0].line != p1[0].line_end:
+	cocci.include_match(False)
+
+@depends on patch@
+position r1.p;
+@@
+-;@p
+
+@script:python depends on report@
+p << r1.p;
+@@
+coccilib.report.print_report(p[0],"Unneeded semicolon")
+
+@depends on context@
+position r1.p;
+@@
+*;@p
+
+@script:python depends on org@
+p << r1.p;
+@@
+cocci.print_main("Unneeded semicolon",p)
@@ -95,7 +95,7 @@
 echo "%endif"
 echo "%endif"
  
-echo 'make %{?_smp_mflags} INSTALL_HDR_PATH=$RPM_BUILD_ROOT/usr headers_install'
+echo 'make %{?_smp_mflags} INSTALL_HDR_PATH=$RPM_BUILD_ROOT/usr KBUILD_SRC= headers_install'
 echo 'cp System.map $RPM_BUILD_ROOT'"/boot/System.map-$KERNELRELEASE"
  
 echo 'cp .config $RPM_BUILD_ROOT'"/boot/config-$KERNELRELEASE"
@@ -217,34 +217,34 @@
 emacs()
 {
 	all_target_sources | xargs $1 -a                        \
-	--regex='/^(ENTRY|_GLOBAL)(\([^)]*\)).*/\2/'            \
+	--regex='/^\(ENTRY\|_GLOBAL\)(\([^)]*\)).*/\2/'         \
 	--regex='/^SYSCALL_DEFINE[0-9]?(\([^,)]*\).*/sys_\1/'   \
 	--regex='/^TRACE_EVENT(\([^,)]*\).*/trace_\1/'		\
 	--regex='/^DEFINE_EVENT([^,)]*, *\([^,)]*\).*/trace_\1/' \
-	--regex='/PAGEFLAG\(([^,)]*).*/Page\1/'			\
-	--regex='/PAGEFLAG\(([^,)]*).*/SetPage\1/'		\
-	--regex='/PAGEFLAG\(([^,)]*).*/ClearPage\1/'		\
-	--regex='/TESTSETFLAG\(([^,)]*).*/TestSetPage\1/'	\
-	--regex='/TESTPAGEFLAG\(([^,)]*).*/Page\1/'		\
-	--regex='/SETPAGEFLAG\(([^,)]*).*/SetPage\1/'		\
-	--regex='/__SETPAGEFLAG\(([^,)]*).*/__SetPage\1/'	\
-	--regex='/TESTCLEARFLAG\(([^,)]*).*/TestClearPage\1/'	\
-	--regex='/__TESTCLEARFLAG\(([^,)]*).*/TestClearPage\1/'	\
-	--regex='/CLEARPAGEFLAG\(([^,)]*).*/ClearPage\1/'	\
-	--regex='/__CLEARPAGEFLAG\(([^,)]*).*/__ClearPage\1/'	\
-	--regex='/__PAGEFLAG\(([^,)]*).*/__SetPage\1/'		\
-	--regex='/__PAGEFLAG\(([^,)]*).*/__ClearPage\1/'	\
-	--regex='/PAGEFLAG_FALSE\(([^,)]*).*/Page\1/'		\
-	--regex='/TESTSCFLAG\(([^,)]*).*/TestSetPage\1/'	\
-	--regex='/TESTSCFLAG\(([^,)]*).*/TestClearPage\1/'	\
-	--regex='/SETPAGEFLAG_NOOP\(([^,)]*).*/SetPage\1/'	\
-	--regex='/CLEARPAGEFLAG_NOOP\(([^,)]*).*/ClearPage\1/'	\
-	--regex='/__CLEARPAGEFLAG_NOOP\(([^,)]*).*/__ClearPage\1/' \
-	--regex='/TESTCLEARFLAG_FALSE\(([^,)]*).*/TestClearPage\1/' \
-	--regex='/__TESTCLEARFLAG_FALSE\(([^,)]*).*/__TestClearPage\1/' \
-	--regex='/_PE\(([^,)]*).*/PEVENT_ERRNO__\1/'		\
-	--regex='/PCI_OP_READ\(([a-z]*[a-z]).*[1-4]\)/pci_bus_read_config_\1/' \
-	--regex='/PCI_OP_WRITE\(([a-z]*[a-z]).*[1-4]\)/pci_bus_write_config_\1/'
+	--regex='/PAGEFLAG(\([^,)]*\).*/Page\1/'			\
+	--regex='/PAGEFLAG(\([^,)]*\).*/SetPage\1/'		\
+	--regex='/PAGEFLAG(\([^,)]*\).*/ClearPage\1/'		\
+	--regex='/TESTSETFLAG(\([^,)]*\).*/TestSetPage\1/'	\
+	--regex='/TESTPAGEFLAG(\([^,)]*\).*/Page\1/'		\
+	--regex='/SETPAGEFLAG(\([^,)]*\).*/SetPage\1/'		\
+	--regex='/__SETPAGEFLAG(\([^,)]*\).*/__SetPage\1/'	\
+	--regex='/TESTCLEARFLAG(\([^,)]*\).*/TestClearPage\1/'	\
+	--regex='/__TESTCLEARFLAG(\([^,)]*\).*/TestClearPage\1/'	\
+	--regex='/CLEARPAGEFLAG(\([^,)]*\).*/ClearPage\1/'	\
+	--regex='/__CLEARPAGEFLAG(\([^,)]*\).*/__ClearPage\1/'	\
+	--regex='/__PAGEFLAG(\([^,)]*\).*/__SetPage\1/'		\
+	--regex='/__PAGEFLAG(\([^,)]*\).*/__ClearPage\1/'	\
+	--regex='/PAGEFLAG_FALSE(\([^,)]*\).*/Page\1/'		\
+	--regex='/TESTSCFLAG(\([^,)]*\).*/TestSetPage\1/'	\
+	--regex='/TESTSCFLAG(\([^,)]*\).*/TestClearPage\1/'	\
+	--regex='/SETPAGEFLAG_NOOP(\([^,)]*\).*/SetPage\1/'	\
+	--regex='/CLEARPAGEFLAG_NOOP(\([^,)]*\).*/ClearPage\1/'	\
+	--regex='/__CLEARPAGEFLAG_NOOP(\([^,)]*\).*/__ClearPage\1/' \
+	--regex='/TESTCLEARFLAG_FALSE(\([^,)]*\).*/TestClearPage\1/' \
+	--regex='/__TESTCLEARFLAG_FALSE(\([^,)]*\).*/__TestClearPage\1/' \
+	--regex='/_PE(\([^,)]*\).*/PEVENT_ERRNO__\1/'		\
+	--regex='/PCI_OP_READ(\([a-z]*[a-z]\).*[1-4])/pci_bus_read_config_\1/' \
+	--regex='/PCI_OP_WRITE(\([a-z]*[a-z]\).*[1-4])/pci_bus_write_config_\1/'
  
 	all_kconfigs | xargs $1 -a                              \
 	--regex='/^[ \t]*\(\(menu\)*config\)[ \t]+\([a-zA-Z0-9_]+\)/\3/'
...	...	@@ -87,6 +87,10 @@
87	87	positives. Thus, reports must be carefully checked, and patches
88	88	reviewed.
89	89
	90	+To enable verbose messages set the V= variable, for example:
	91	+
	92	+ make coccicheck MODE=report V=1
	93	+
90	94
91	95	Using Coccinelle with a single semantic patch
92	96	~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...	...	@@ -2,6 +2,15 @@
2	2
3	3	SPATCH="`which ${SPATCH:=spatch}`"
4	4
	5	+# The verbosity may be set by the environmental parameter V=
	6	+# as for example with 'make V=1 coccicheck'
	7	+
	8	+if [ -n "$V" -a "$V" != "0" ]; then
	9	+ VERBOSE=1
	10	+else
	11	+ VERBOSE=0
	12	+fi
	13	+
5	14	if [ "$C" = "1" -o "$C" = "2" ]; then
6	15	ONLINE=1
7	16
...	...	@@ -46,6 +55,14 @@
46	55	echo ''
47	56	fi
48	57
	58	+run_cmd() {
	59	+ if [ $VERBOSE -ne 0 ] ; then
	60	+ echo "Running: $@"
	61	+ fi
	62	+ eval $@
	63	+}
	64	+
	65	+
49	66	coccinelle () {
50	67	COCCI="$1"
51	68
...	...	@@ -55,7 +72,7 @@
55	72	#
56	73	# $SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null
57	74
58		- if [ "$ONLINE" = "0" ] ; then
	75	+ if [ $VERBOSE -ne 0 ] ; then
59	76
60	77	FILE=`echo $COCCI \| sed "s\|$srctree/\|\|"`
61	78
62	79
63	80
...	...	@@ -91,15 +108,21 @@
91	108	fi
92	109
93	110	if [ "$MODE" = "chain" ] ; then
94		- $SPATCH -D patch $FLAGS -sp_file $COCCI $OPT $OPTIONS \|\| \
95		- $SPATCH -D report $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff \|\| \
96		- $SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS \|\| \
97		- $SPATCH -D org $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff \|\| exit 1
	111	+ run_cmd $SPATCH -D patch \
	112	+ $FLAGS -sp_file $COCCI $OPT $OPTIONS \|\| \
	113	+ run_cmd $SPATCH -D report \
	114	+ $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff \|\| \
	115	+ run_cmd $SPATCH -D context \
	116	+ $FLAGS -sp_file $COCCI $OPT $OPTIONS \|\| \
	117	+ run_cmd $SPATCH -D org \
	118	+ $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff \|\| exit 1
98	119	elif [ "$MODE" = "rep+ctxt" ] ; then
99		- $SPATCH -D report $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff && \
100		- $SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS \|\| exit 1
	120	+ run_cmd $SPATCH -D report \
	121	+ $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff && \
	122	+ run_cmd $SPATCH -D context \
	123	+ $FLAGS -sp_file $COCCI $OPT $OPTIONS \|\| exit 1
101	124	else
102		- $SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT $OPTIONS \|\| exit 1
	125	+ run_cmd $SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT $OPTIONS \|\| exit 1
103	126	fi
104	127
105	128	}
	1	+//
	2	+// Replace memcpy with struct assignment.
	3	+//
	4	+// Confidence: High
	5	+// Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6. GPLv2.
	6	+// URL: http://coccinelle.lip6.fr/
	7	+// Comments:
	8	+// Options: --no-includes --include-headers
	9	+
	10	+virtual patch
	11	+virtual report
	12	+virtual context
	13	+virtual org
	14	+
	15	+@r1 depends on !patch@
	16	+identifier struct_name;
	17	+struct struct_name to;
	18	+struct struct_name from;
	19	+struct struct_name *top;
	20	+struct struct_name *fromp;
	21	+position p;
	22	+@@
	23	+memcpy@p(\(&(to)\\|top\), \(&(from)\\|fromp\), \(sizeof(to)\\|sizeof(from)\\|sizeof(struct struct_name)\\|sizeof(top)\\|sizeof(fromp)\))
	24	+
	25	+@script:python depends on report@
	26	+p << r1.p;
	27	+@@
	28	+coccilib.report.print_report(p[0],"Replace memcpy with struct assignment")
	29	+
	30	+@depends on context@
	31	+position r1.p;
	32	+@@
	33	+*memcpy@p(...);
	34	+
	35	+@script:python depends on org@
	36	+p << r1.p;
	37	+@@
	38	+cocci.print_main("Replace memcpy with struct assignment",p)
	39	+
	40	+@depends on patch@
	41	+identifier struct_name;
	42	+struct struct_name to;
	43	+struct struct_name from;
	44	+@@
	45	+(
	46	+-memcpy(&(to), &(from), sizeof(to));
	47	++to = from;
	48	+\|
	49	+-memcpy(&(to), &(from), sizeof(from));
	50	++to = from;
	51	+\|
	52	+-memcpy(&(to), &(from), sizeof(struct struct_name));
	53	++to = from;
	54	+)
	55	+
	56	+@depends on patch@
	57	+identifier struct_name;
	58	+struct struct_name to;
	59	+struct struct_name *from;
	60	+@@
	61	+(
	62	+-memcpy(&(to), from, sizeof(to));
	63	++to = *from;
	64	+\|
	65	+-memcpy(&(to), from, sizeof(*from));
	66	++to = *from;
	67	+\|
	68	+-memcpy(&(to), from, sizeof(struct struct_name));
	69	++to = *from;
	70	+)
	71	+
	72	+@depends on patch@
	73	+identifier struct_name;
	74	+struct struct_name *to;
	75	+struct struct_name from;
	76	+@@
	77	+(
	78	+-memcpy(to, &(from), sizeof(*to));
	79	++ *to = from;
	80	+\|
	81	+-memcpy(to, &(from), sizeof(from));
	82	++ *to = from;
	83	+\|
	84	+-memcpy(to, &(from), sizeof(struct struct_name));
	85	++ *to = from;
	86	+)
	87	+
	88	+@depends on patch@
	89	+identifier struct_name;
	90	+struct struct_name *to;
	91	+struct struct_name *from;
	92	+@@
	93	+(
	94	+-memcpy(to, from, sizeof(*to));
	95	++ to = from;
	96	+\|
	97	+-memcpy(to, from, sizeof(*from));
	98	++ to = from;
	99	+\|
	100	+-memcpy(to, from, sizeof(struct struct_name));
	101	++ to = from;
	102	+)
	1	+/// Check for constants that are added but are used elsewhere as bitmasks
	2	+/// The results should be checked manually to ensure that the nonzero
	3	+/// bits in the two constants are actually disjoint.
	4	+///
	5	+// Confidence: Moderate
	6	+// Copyright: (C) 2013 Julia Lawall, INRIA/LIP6. GPLv2.
	7	+// Copyright: (C) 2013 Gilles Muller, INRIA/LIP6. GPLv2.
	8	+// URL: http://coccinelle.lip6.fr/
	9	+// Comments:
	10	+// Options: -no_includes -include_headers
	11	+
	12	+virtual org
	13	+virtual report
	14	+virtual context
	15	+
	16	+@r@
	17	+constant c;
	18	+identifier i;
	19	+expression e;
	20	+@@
	21	+
	22	+(
	23	+e \| c@i
	24	+\|
	25	+e & c@i
	26	+\|
	27	+e \|= c@i
	28	+\|
	29	+e &= c@i
	30	+)
	31	+
	32	+@s@
	33	+constant r.c,c1;
	34	+identifier i1;
	35	+position p;
	36	+@@
	37	+
	38	+(
	39	+ c1 + c - 1
	40	+\|
	41	+*c1@i1 +@p c
	42	+)
	43	+
	44	+@script:python depends on org@
	45	+p << s.p;
	46	+@@
	47	+
	48	+cocci.print_main("sum of probable bitmasks, consider \|",p)
	49	+
	50	+@script:python depends on report@
	51	+p << s.p;
	52	+@@
	53	+
	54	+msg = "WARNING: sum of probable bitmasks, consider \|"
	55	+coccilib.report.print_report(p[0],msg)
	1	+///
	2	+/// Removes unneeded semicolon.
	3	+///
	4	+// Confidence: Moderate
	5	+// Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6. GPLv2.
	6	+// URL: http://coccinelle.lip6.fr/
	7	+// Comments: Some false positives on empty default cases in switch statements.
	8	+// Options: --no-includes --include-headers
	9	+
	10	+virtual patch
	11	+virtual report
	12	+virtual context
	13	+virtual org
	14	+
	15	+@r_default@
	16	+position p;
	17	+@@
	18	+switch (...)
	19	+{
	20	+default: ...;@p
	21	+}
	22	+
	23	+@r_case@
	24	+position p;
	25	+@@
	26	+(
	27	+switch (...)
	28	+{
	29	+case ...:;@p
	30	+}
	31	+\|
	32	+switch (...)
	33	+{
	34	+case ...:...
	35	+case ...:;@p
	36	+}
	37	+\|
	38	+switch (...)
	39	+{
	40	+case ...:...
	41	+case ...:
	42	+case ...:;@p
	43	+}
	44	+)
	45	+
	46	+@r1@
	47	+statement S;
	48	+position p1;
	49	+position p != {r_default.p, r_case.p};
	50	+identifier label;
	51	+@@
	52	+(
	53	+label:;
	54	+\|
	55	+S@p1;@p
	56	+)
	57	+
	58	+@script:python@
	59	+p << r1.p;
	60	+p1 << r1.p1;
	61	+@@
	62	+if p[0].line != p1[0].line_end:
	63	+ cocci.include_match(False)
	64	+
	65	+@depends on patch@
	66	+position r1.p;
	67	+@@
	68	+-;@p
	69	+
	70	+@script:python depends on report@
	71	+p << r1.p;
	72	+@@
	73	+coccilib.report.print_report(p[0],"Unneeded semicolon")
	74	+
	75	+@depends on context@
	76	+position r1.p;
	77	+@@
	78	+*;@p
	79	+
	80	+@script:python depends on org@
	81	+p << r1.p;
	82	+@@
	83	+cocci.print_main("Unneeded semicolon",p)
...	...	@@ -95,7 +95,7 @@
95	95	echo "%endif"
96	96	echo "%endif"
97	97
98		-echo 'make %{?_smp_mflags} INSTALL_HDR_PATH=$RPM_BUILD_ROOT/usr headers_install'
	98	+echo 'make %{?_smp_mflags} INSTALL_HDR_PATH=$RPM_BUILD_ROOT/usr KBUILD_SRC= headers_install'
99	99	echo 'cp System.map $RPM_BUILD_ROOT'"/boot/System.map-$KERNELRELEASE"
100	100
101	101	echo 'cp .config $RPM_BUILD_ROOT'"/boot/config-$KERNELRELEASE"
...	...	@@ -217,34 +217,34 @@
217	217	emacs()
218	218	{
219	219	all_target_sources \| xargs $1 -a \
220		- --regex='/^(ENTRY\|_GLOBAL)(\([^)]\))./\2/' \
	220	+ --regex='/^\(ENTRY\\|_GLOBAL\)(\([^)]\))./\2/' \
221	221	--regex='/^SYSCALL_DEFINE[0-9]?(\([^,)]\)./sys_\1/' \
222	222	--regex='/^TRACE_EVENT(\([^,)]\)./trace_\1/' \
223	223	--regex='/^DEFINE_EVENT([^,)], \([^,)]\)./trace_\1/' \
224		- --regex='/PAGEFLAG\(([^,)])./Page\1/' \
225		- --regex='/PAGEFLAG\(([^,)])./SetPage\1/' \
226		- --regex='/PAGEFLAG\(([^,)])./ClearPage\1/' \
227		- --regex='/TESTSETFLAG\(([^,)])./TestSetPage\1/' \
228		- --regex='/TESTPAGEFLAG\(([^,)])./Page\1/' \
229		- --regex='/SETPAGEFLAG\(([^,)])./SetPage\1/' \
230		- --regex='/__SETPAGEFLAG\(([^,)])./__SetPage\1/' \
231		- --regex='/TESTCLEARFLAG\(([^,)])./TestClearPage\1/' \
232		- --regex='/__TESTCLEARFLAG\(([^,)])./TestClearPage\1/' \
233		- --regex='/CLEARPAGEFLAG\(([^,)])./ClearPage\1/' \
234		- --regex='/__CLEARPAGEFLAG\(([^,)])./__ClearPage\1/' \
235		- --regex='/__PAGEFLAG\(([^,)])./__SetPage\1/' \
236		- --regex='/__PAGEFLAG\(([^,)])./__ClearPage\1/' \
237		- --regex='/PAGEFLAG_FALSE\(([^,)])./Page\1/' \
238		- --regex='/TESTSCFLAG\(([^,)])./TestSetPage\1/' \
239		- --regex='/TESTSCFLAG\(([^,)])./TestClearPage\1/' \
240		- --regex='/SETPAGEFLAG_NOOP\(([^,)])./SetPage\1/' \
241		- --regex='/CLEARPAGEFLAG_NOOP\(([^,)])./ClearPage\1/' \
242		- --regex='/__CLEARPAGEFLAG_NOOP\(([^,)])./__ClearPage\1/' \
243		- --regex='/TESTCLEARFLAG_FALSE\(([^,)])./TestClearPage\1/' \
244		- --regex='/__TESTCLEARFLAG_FALSE\(([^,)])./__TestClearPage\1/' \
245		- --regex='/_PE\(([^,)])./PEVENT_ERRNO__\1/' \
246		- --regex='/PCI_OP_READ\(([a-z][a-z]).[1-4]\)/pci_bus_read_config_\1/' \
247		- --regex='/PCI_OP_WRITE\(([a-z][a-z]).[1-4]\)/pci_bus_write_config_\1/'
	224	+ --regex='/PAGEFLAG(\([^,)]\)./Page\1/' \
	225	+ --regex='/PAGEFLAG(\([^,)]\)./SetPage\1/' \
	226	+ --regex='/PAGEFLAG(\([^,)]\)./ClearPage\1/' \
	227	+ --regex='/TESTSETFLAG(\([^,)]\)./TestSetPage\1/' \
	228	+ --regex='/TESTPAGEFLAG(\([^,)]\)./Page\1/' \
	229	+ --regex='/SETPAGEFLAG(\([^,)]\)./SetPage\1/' \
	230	+ --regex='/__SETPAGEFLAG(\([^,)]\)./__SetPage\1/' \
	231	+ --regex='/TESTCLEARFLAG(\([^,)]\)./TestClearPage\1/' \
	232	+ --regex='/__TESTCLEARFLAG(\([^,)]\)./TestClearPage\1/' \
	233	+ --regex='/CLEARPAGEFLAG(\([^,)]\)./ClearPage\1/' \
	234	+ --regex='/__CLEARPAGEFLAG(\([^,)]\)./__ClearPage\1/' \
	235	+ --regex='/__PAGEFLAG(\([^,)]\)./__SetPage\1/' \
	236	+ --regex='/__PAGEFLAG(\([^,)]\)./__ClearPage\1/' \
	237	+ --regex='/PAGEFLAG_FALSE(\([^,)]\)./Page\1/' \
	238	+ --regex='/TESTSCFLAG(\([^,)]\)./TestSetPage\1/' \
	239	+ --regex='/TESTSCFLAG(\([^,)]\)./TestClearPage\1/' \
	240	+ --regex='/SETPAGEFLAG_NOOP(\([^,)]\)./SetPage\1/' \
	241	+ --regex='/CLEARPAGEFLAG_NOOP(\([^,)]\)./ClearPage\1/' \
	242	+ --regex='/__CLEARPAGEFLAG_NOOP(\([^,)]\)./__ClearPage\1/' \
	243	+ --regex='/TESTCLEARFLAG_FALSE(\([^,)]\)./TestClearPage\1/' \
	244	+ --regex='/__TESTCLEARFLAG_FALSE(\([^,)]\)./__TestClearPage\1/' \
	245	+ --regex='/_PE(\([^,)]\)./PEVENT_ERRNO__\1/' \
	246	+ --regex='/PCI_OP_READ(\([a-z][a-z]\).[1-4])/pci_bus_read_config_\1/' \
	247	+ --regex='/PCI_OP_WRITE(\([a-z][a-z]\).[1-4])/pci_bus_write_config_\1/'
248	248
249	249	all_kconfigs \| xargs $1 -a \
250	250	--regex='/^[ \t]\(\(menu\)config\)[ \t]+\([a-zA-Z0-9_]+\)/\3/'