Commit ae89254da6879cffa6a17327e5f3f60217b718cf

Authored by J. Bruce Fields
1 parent 18c01ab302

SUNRPC: Fix compile on non-x86

current_task appears to be x86-only, oops.

Let's just delete this check entirely:

Any developer that adds a new user without setting rq_task will get a
crash the first time they test it.  I also don't think there are
normally any important locks held here, and I can't see any other reason
why killing a server thread would bring the whole box down.

So the effort to fail gracefully here looks like overkill.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 983c684466e0 "SUNRPC: get rid of the request wait queue"
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

Showing 1 changed file with 0 additions and 4 deletions Side-by-side Diff

net/sunrpc/svc_xprt.c
... ... @@ -771,10 +771,6 @@
771 771 "svc_recv: service %p, transport not NULL!\n",
772 772 rqstp);
773 773  
774   - /* Make sure the task pointer is set! */
775   - if (WARN_ON_ONCE(!rqstp->rq_task))
776   - rqstp->rq_task = current_task;
777   -
778 774 err = svc_alloc_arg(rqstp);
779 775 if (err)
780 776 return err;