create_mnt_ns: unidiomatic use of list_add()

while list_add(A, B) and list_add(B, A) are equivalent when both A and B are guaranteed to be empty, the usual idiom is list_add(what, where), not the other way round... Not a bug per se, but only by accident and it makes RTFS harder for no good reason. Spotted-by: Rajat Sharma <fs.rajat@gmail.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

create_mnt_ns: unidiomatic use of list_add()
while list_add(A, B) and list_add(B, A) are equivalent when both A and B are guaranteed to be empty, the usual idiom is list_add(what, where), not the other way round... Not a bug per se, but only by accident and it makes RTFS harder for no good reason. Spotted-by: Rajat Sharma <fs.rajat@gmail.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Al Viro
1 parent 61572bb1f4
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
fs/namespace.c
@@ -2463,7 +2463,7 @@
 		struct mount *mnt = real_mount(m);
 		mnt->mnt_ns = new_ns;
 		new_ns->root = mnt;
-		list_add(&new_ns->list, &mnt->mnt_list);
+		list_add(&mnt->mnt_list, &new_ns->list);
 	} else {
 		mntput(m);
 	}
...	...	@@ -2463,7 +2463,7 @@
2463	2463	struct mount *mnt = real_mount(m);
2464	2464	mnt->mnt_ns = new_ns;
2465	2465	new_ns->root = mnt;
2466		- list_add(&new_ns->list, &mnt->mnt_list);
	2466	+ list_add(&mnt->mnt_list, &new_ns->list);
2467	2467	} else {
2468	2468	mntput(m);
2469	2469	}