Commit b9b97d5b16eae2f429c7742c9885104379f46338

Authored by Eric W. Biederman
Committed by Greg Kroah-Hartman
1 parent d5c3ebc439

userns: Don't allow unprivileged creation of gid mappings

commit be7c6dba2332cef0677fbabb606e279ae76652c3 upstream.

As any gid mapping will allow and must allow for backwards
compatibility dropping groups don't allow any gid mappings to be
established without CAP_SETGID in the parent user namespace.

For a small class of applications this change breaks userspace
and removes useful functionality.  This small class of applications
includes tools/testing/selftests/mount/unprivilged-remount-test.c

Most of the removed functionality will be added back with the addition
of a one way knob to disable setgroups.  Once setgroups is disabled
setting the gid_map becomes as safe as setting the uid_map.

For more common applications that set the uid_map and the gid_map
with privilege this change will have no affect.

This is part of a fix for CVE-2014-8989.

Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 0 additions and 4 deletions Side-by-side Diff

kernel/user_namespace.c
... ... @@ -821,10 +821,6 @@
821 821 kuid_t uid = make_kuid(ns->parent, id);
822 822 if (uid_eq(uid, file->f_cred->fsuid))
823 823 return true;
824   - } else if (cap_setid == CAP_SETGID) {
825   - kgid_t gid = make_kgid(ns->parent, id);
826   - if (gid_eq(gid, file->f_cred->fsgid))
827   - return true;
828 824 }
829 825 }
830 826