Eric Lee / smarc-ti-linux-kernel

5
Download as
Browse Code ยป

Commit bcdbc084ebab447f6eb1add7b953f125b0c8174b

Authored by Alexandre Belloni
Committed by Felipe Balbi
1 parent 4d9f872ced
Exists in ti-lsk-linux-4.1.y and in 10 other branches dlt-processor-sdk-linux-03.00.00.04, processor-sdk-linux-02.00.01, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04

usb: gadget: atmel_usba: always test udc->driver 

Found using smatch: drivers/usb/gadget/atmel_usba_udc.c:1689 usba_udc_irq()
error: we previously assumed 'udc->driver' could be null (see line 1636)

Always test udc->driver before using its members.

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/usb/gadget/atmel_usba_udc.c
Diff comments   View file @ bcdbc08
... ... @@ -1686,7 +1686,7 @@
1686 1686 reset_all_endpoints(udc);
1687 1687  
1688 1688 if (udc->gadget.speed != USB_SPEED_UNKNOWN
1689   - && udc->driver->disconnect) {
  1689 + && udc->driver && udc->driver->disconnect) {
1690 1690 udc->gadget.speed = USB_SPEED_UNKNOWN;
1691 1691 spin_unlock(&udc->lock);
1692 1692 udc->driver->disconnect(&udc->gadget);