Commit c297abfdf15b4480704d6b566ca5ca9438b12456

Authored by Eric W. Biederman
Committed by Linus Torvalds
1 parent 44e8967d59

mnt: Fix a memory stomp in umount

While reviewing the code of umount_tree I realized that when we append
to a preexisting unmounted list we do not change pprev of the former
first item in the list.

Which means later in namespace_unlock hlist_del_init(&mnt->mnt_hash) on
the former first item of the list will stomp unmounted.first leaving
it set to some random mount point which we are likely to free soon.

This isn't likely to hit, but if it does I don't know how anyone could
track it down.

[ This happened because we don't have all the same operations for
  hlist's as we do for normal doubly-linked lists. In particular,
  list_splice() is easy on our standard doubly-linked lists, while
  hlist_splice() doesn't exist and needs both start/end entries of the
  hlist.  And commit 38129a13e6e7 incorrectly open-coded that missing
  hlist_splice().

  We should think about making these kinds of "mindless" conversions
  easier to get right by adding the missing hlist helpers   - Linus ]

Fixes: 38129a13e6e71f666e0468e99fdd932a687b4d7e switch mnt_hash to hlist
Cc: stable@vger.kernel.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff

... ... @@ -1370,6 +1370,8 @@
1370 1370 }
1371 1371 if (last) {
1372 1372 last->mnt_hash.next = unmounted.first;
  1373 + if (unmounted.first)
  1374 + unmounted.first->pprev = &last->mnt_hash.next;
1373 1375 unmounted.first = tmp_list.first;
1374 1376 unmounted.first->pprev = &unmounted.first;
1375 1377 }