Commit c2c80529460095035752bf0ecc1af82c1e0f6e0f

Authored by Al Viro
Committed by Ingo Molnar
1 parent 45beca08dd

tracing, alpha: undefined reference to `save_stack_trace'

Impact: build fix on !stacktrace architectures

only select STACKTRACE on architectures that have STACKTRACE_SUPPORT

... since we also need to ifdef out the guts of ftrace_trace_stack().
We also want to disallow setting TRACE_ITER_STACKTRACE in trace_flags
on such configs, but that can wait.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

Showing 2 changed files with 3 additions and 1 deletions Side-by-side Diff

kernel/trace/Kconfig
... ... @@ -25,7 +25,7 @@
25 25 bool
26 26 select DEBUG_FS
27 27 select RING_BUFFER
28   - select STACKTRACE
  28 + select STACKTRACE if STACKTRACE_SUPPORT
29 29 select TRACEPOINTS
30 30 select NOP_TRACER
31 31  
kernel/trace/trace.c
... ... @@ -705,6 +705,7 @@
705 705 unsigned long flags,
706 706 int skip, int pc)
707 707 {
  708 +#ifdef CONFIG_STACKTRACE
708 709 struct ring_buffer_event *event;
709 710 struct stack_entry *entry;
710 711 struct stack_trace trace;
... ... @@ -730,6 +731,7 @@
730 731  
731 732 save_stack_trace(&trace);
732 733 ring_buffer_unlock_commit(tr->buffer, event, irq_flags);
  734 +#endif
733 735 }
734 736  
735 737 void __trace_stack(struct trace_array *tr,