Eric Lee / smarc-ti-linux-kernel

5
Download as
Browse Code ยป

Commit c92cdeb45eea38515e82187f48c2e4f435fb4e25

Authored by Richard Guy Briggs
Committed by Eric Paris
1 parent ad36d28293
Exists in master and in 13 other branches dlt-processor-sdk-linux-03.00.00.04, processor-sdk-linux-02.00.01, smarc-ti-linux-3.15.y, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04, ti-linux-3.15.y, ti-lsk-linux-4.1.y

audit: convert PPIDs to the inital PID namespace. 

sys_getppid() returns the parent pid of the current process in its own pid
namespace.  Since audit filters are based in the init pid namespace, a process
could avoid a filter or trigger an unintended one by being in an alternate pid
namespace or log meaningless information.

Switch to task_ppid_nr() for PPIDs to anchor all audit filters in the
init_pid_ns.

(informed by ebiederman's 6c621b7e)
Cc: stable@vger.kernel.org
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>

Showing 2 changed files with 3 additions and 3 deletions Side-by-side Diff

... ... @@ -1819,10 +1819,10 @@
1819 1819 spin_unlock_irq(&tsk->sighand->siglock);
1820 1820  
1821 1821 audit_log_format(ab,
1822   - " ppid=%ld pid=%d auid=%u uid=%u gid=%u"
  1822 + " ppid=%d pid=%d auid=%u uid=%u gid=%u"
1823 1823 " euid=%u suid=%u fsuid=%u"
1824 1824 " egid=%u sgid=%u fsgid=%u tty=%s ses=%u",
1825   - sys_getppid(),
  1825 + task_ppid_nr(tsk),
1826 1826 tsk->pid,
1827 1827 from_kuid(&init_user_ns, audit_get_loginuid(tsk)),
1828 1828 from_kuid(&init_user_ns, cred->uid),
... ... @@ -465,7 +465,7 @@
465 465 case AUDIT_PPID:
466 466 if (ctx) {
467 467 if (!ctx->ppid)
468   - ctx->ppid = sys_getppid();
  468 + ctx->ppid = task_ppid_nr(tsk);
469 469 result = audit_comparator(ctx->ppid, f->op, f->val);
470 470 }
471 471 break;