ps3: vuart: fix error path locking

This stray down would cause a permanent sleep which doesn't seem correct. The other uses of this semaphore appear fairly mutex like it's even initialized with init_MUTEX() .. So here a patch for removing this one down(). Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> Signed-off-by: Daniel Walker <dwalker@mvista.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

ps3: vuart: fix error path locking
This stray down would cause a permanent sleep which doesn't seem correct. The other uses of this semaphore appear fairly mutex like it's even initialized with init_MUTEX() .. So here a patch for removing this one down(). Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> Signed-off-by: Daniel Walker <dwalker@mvista.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Daniel Walker · Linus Torvalds
1 parent 04bdfb9191
Showing 1 changed file with 0 additions and 1 deletions Side-by-side Diff
drivers/ps3/ps3-vuart.c
@@ -1074,7 +1074,6 @@
 	if (result) {
 		dev_dbg(&dev->core, "%s:%d: drv->probe failed\n",
 			__func__, __LINE__);
-		down(&vuart_bus_priv.probe_mutex);
 		goto fail_probe;
 	}
...	...	@@ -1074,7 +1074,6 @@
1074	1074	if (result) {
1075	1075	dev_dbg(&dev->core, "%s:%d: drv->probe failed\n",
1076	1076	__func__, __LINE__);
1077		- down(&vuart_bus_priv.probe_mutex);
1078	1077	goto fail_probe;
1079	1078	}
1080	1079