Commit d03b29a271eb1d6de5af0f46cf0e7487e9e9284b
Committed by
Al Viro
Al Viro
1 parent
b8faf035ea
Exists in
ti-lsk-linux-4.1.y
and in
10 other branches
namei: trivial fix to vfs_rename_dir comment
Looks like the directory loop check is actually done in renameat? Whatever, leave this out rather than trying to keep it up to date with the code. Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
fs/namei.c
| ... | ... | @@ -4024,7 +4024,7 @@ |
| 4024 | 4024 | * The worst of all namespace operations - renaming directory. "Perverted" |
| 4025 | 4025 | * doesn't even start to describe it. Somebody in UCB had a heck of a trip... |
| 4026 | 4026 | * Problems: |
| 4027 | - * a) we can get into loop creation. Check is done in is_subdir(). | |
| 4027 | + * a) we can get into loop creation. | |
| 4028 | 4028 | * b) race potential - two innocent renames can create a loop together. |
| 4029 | 4029 | * That's where 4.4 screws up. Current fix: serialization on |
| 4030 | 4030 | * sb->s_vfs_rename_mutex. We might be more accurate, but that's another |