Eric Lee / smarc-ti-linux-kernel | Embedian Git Server

Commit d136f2efdf3a4faba47f58603f8ace2207234d75

Authored by Alasdair G Kergon 2011-10-24 03:55:17 +0800

dm kcopyd: fix job_pool leak

Fix memory leak introduced by commit a6e50b409d3f9e0833e69c3c9cca822e8fa4adbb
(dm snapshot: skip reading origin when overwriting complete chunk).

When allocating a set of jobs from kc->job_pool, job->master_job must be
set (to point to itself) so that the mempool item gets freed when the
master_job completes.

master_job was introduced by commit c6ea41fbbe08f270a8edef99dc369faf809d1bd6
(dm kcopyd: preallocate sub jobs to avoid deadlock)

Reported-by: Michael Leun <ml@newton.leun.net>
Cc: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

drivers/md/dm-kcopyd.c

drivers/md/dm-kcopyd.c

Diff comments View file @ d136f2e

...	...	@@ -628,6 +628,7 @@
628	628	job->kc = kc;
629	629	job->fn = fn;
630	630	job->context = context;
	631	+ job->master_job = job;
631	632
632	633	atomic_inc(&kc->nr_jobs);
633	634