Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit d81931d9a2ec3e2e2cd8238b72f20c5fe44ccc7b

Authored by Eric Sesterhenn
Committed by Linus Torvalds
1 parent 9dc3885dfb
Exists in master and in 20 other branches dlt-processor-sdk-linux-03.00.00.04, newt-ti-linux-3.12.y, processor-sdk-linux-01.00.00, processor-sdk-linux-02.00.01, smarc-ti-linux-3.12.10, smarc-ti-linux-3.12.y, smarc-ti-linux-3.14.y, smarc-ti-linux-3.15.y, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04, ti-linux-3.12.y, ti-linux-3.14.y, ti-linux-3.15.y, ti-lsk-linux-4.1.y

[PATCH] SKB leak in drivers/isdn/i4l/isdn_x25iface.c 

Coverity spotted this leak (id #613), when we are not configured, we return
without freeing the allocated skb.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 1 changed file with 3 additions and 1 deletions Side-by-side Diff

drivers/isdn/i4l/isdn_x25iface.c
Diff comments   View file @ d81931d
... ... @@ -208,7 +208,7 @@
208 208 */
209 209 static int isdn_x25iface_connect_ind(struct concap_proto *cprot)
210 210 {
211   - struct sk_buff * skb = dev_alloc_skb(1);
  211 + struct sk_buff * skb;
212 212 enum wan_states *state_p
213 213 = &( ( (ix25_pdata_t*) (cprot->proto_data) ) -> state);
214 214 IX25DEBUG( "isdn_x25iface_connect_ind %s \n"
... ... @@ -220,6 +220,8 @@
220 220 return -1;
221 221 }
222 222 *state_p = WAN_CONNECTED;
  223 +
  224 + skb = dev_alloc_skb(1);
223 225 if( skb ){
224 226 *( skb_put(skb, 1) ) = 0x01;
225 227 skb->protocol = x25_type_trans(skb, cprot->net_dev);