Commit d98808a253f209465ed9f415c565f4c294a213b8

Authored by Julia Lawall
Committed by Linus Torvalds
1 parent e2e7709876

drivers/char/ppdev.c: put gotten port value

parport_find_number() calls parport_get_port() on its result, so there
should be a corresponding call to parport_put_port() before dropping the
reference.  Similar code is found in the function register_device() in the
same file.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

  // <smpl>
  @exists@
  local idexpression struct parport * x;
  expression ra,rr;
  statement S1,S2;
  @@

  x = parport_find_number(...)
  ... when != x = rr
      when any
      when != parport_put_port(x,...)
      when != if (...) { ... parport_put_port(x,...) ...}
  (
  if(<+...x...+>) S1 else S2
  |
  if(...) { ... when != x = ra
       when forall
       when != parport_put_port(x,...)
  *return...;
  }
  )
  // </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

drivers/char/ppdev.c
... ... @@ -457,6 +457,7 @@
457 457 return -ENODEV;
458 458  
459 459 modes = port->modes;
  460 + parport_put_port(port);
460 461 if (copy_to_user (argp, &modes, sizeof (modes))) {
461 462 return -EFAULT;
462 463 }