Commit d9a74df512e44580a34bf6e70f5d08c126507354
Committed by
Jens Axboe
1 parent
8b4922d317
Exists in
master
and in
13 other branches
block: Remove useless IPI struct initialization
rq_fifo_clear() reset the csd.list through INIT_LIST_HEAD for no clear purpose. The csd.list doesn't need to be initialized as a list head because it's only ever used as a list node. Lets remove this useless initialization. Reviewed-by: Jan Kara <jack@suse.cz> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Christoph Hellwig <hch@infradead.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jan Kara <jack@suse.cz> Cc: Jens Axboe <axboe@fb.com> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Signed-off-by: Jens Axboe <axboe@fb.com>
Showing 1 changed file with 1 additions and 4 deletions Side-by-side Diff
include/linux/elevator.h
... | ... | @@ -203,10 +203,7 @@ |
203 | 203 | #define rb_entry_rq(node) rb_entry((node), struct request, rb_node) |
204 | 204 | |
205 | 205 | #define rq_entry_fifo(ptr) list_entry((ptr), struct request, queuelist) |
206 | -#define rq_fifo_clear(rq) do { \ | |
207 | - list_del_init(&(rq)->queuelist); \ | |
208 | - INIT_LIST_HEAD(&(rq)->csd.list); \ | |
209 | - } while (0) | |
206 | +#define rq_fifo_clear(rq) list_del_init(&(rq)->queuelist) | |
210 | 207 | |
211 | 208 | #else /* CONFIG_BLOCK */ |
212 | 209 |