Commit db1806edcfef007d9594435a331dcf7e7f1b8fac

Authored by Alexey Brodkin
Committed by Arnaldo Carvalho de Melo
1 parent 25cd480e44

perf tools: Fix statfs.f_type data type mismatch build error with uclibc

ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers
statfs defines f_type to be U32 which causes perf build breakage

http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h

  ----------->8---------------
    CC       fs/fs.o
  fs/fs.c: In function 'fs__valid_mount':
  fs/fs.c:82:24: error: comparison between signed and unsigned integer
  expressions [-Werror=sign-compare]
    else if (st_fs.f_type != magic)
                          ^
  cc1: all warnings being treated as errors
  ----------->8---------------

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Borislav Petkov <bp@suse.de>
Cc: Cody P Schafer <dev@codyps.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Link: http://lkml.kernel.org/r/1420888254-17504-2-git-send-email-vgupta@synopsys.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Showing 2 changed files with 2 additions and 2 deletions Side-by-side Diff

tools/lib/api/fs/debugfs.c
... ... @@ -67,7 +67,7 @@
67 67  
68 68 if (statfs(debugfs, &st_fs) < 0)
69 69 return -ENOENT;
70   - else if (st_fs.f_type != (long) DEBUGFS_MAGIC)
  70 + else if ((long)st_fs.f_type != (long)DEBUGFS_MAGIC)
71 71 return -ENOENT;
72 72  
73 73 return 0;
tools/lib/api/fs/fs.c
... ... @@ -79,7 +79,7 @@
79 79  
80 80 if (statfs(fs, &st_fs) < 0)
81 81 return -ENOENT;
82   - else if (st_fs.f_type != magic)
  82 + else if ((long)st_fs.f_type != magic)
83 83 return -ENOENT;
84 84  
85 85 return 0;