Eric Lee / smarc-ti-linux-kernel | Embedian Git Server

Commit dfd5d5692c7ddf27380511b80a3dc590acfc4eee

Authored by Asias He 2013-04-03 14:17:38 +0800

Committed by Nicholas Bellinger 2013-04-09 05:09:54 +0800

tcm_vhost: Initialize vq->last_used_idx when set endpoint

This patch fixes guest hang when booting seabios and guest.

  [    0.576238] scsi0 : Virtio SCSI HBA
  [    0.616754] virtio_scsi virtio1: request:id 0 is not a head!

vq->last_used_idx is initialized only when /dev/vhost-scsi is
opened or closed.

   vhost_scsi_open -> vhost_dev_init() -> vhost_vq_reset()
   vhost_scsi_release() -> vhost_dev_cleanup -> vhost_vq_reset()

So, when guest talks to tcm_vhost after seabios does, vq->last_used_idx
still contains the old valule for seabios. This confuses guest.

Fix this by calling vhost_init_used() to init vq->last_used_idx when
we set endpoint.

Signed-off-by: Asias He <asias@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

drivers/vhost/tcm_vhost.c

drivers/vhost/tcm_vhost.c

Diff comments View file @ dfd5d56

...	...	@@ -874,6 +874,7 @@
874	874	/* Flushing the vhost_work acts as synchronize_rcu */
875	875	mutex_lock(&vq->mutex);
876	876	rcu_assign_pointer(vq->private_data, vs_tpg);
	877	+ vhost_init_used(vq);
877	878	mutex_unlock(&vq->mutex);
878	879	}
879	880	ret = 0;