Eric Lee / smarc-ti-linux-kernel

13
Download as
Browse Code ยป

Commit e173fb2646a832b424c80904c306b816760ce477

Authored by Richard Guy Briggs
Committed by Paul Moore
1 parent cbe0d6e879
Exists in ti-lsk-linux-4.1.y and in 10 other branches dlt-processor-sdk-linux-03.00.00.04, processor-sdk-linux-02.00.01, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04

selinux: cleanup error reporting in selinux_nlmsg_perm() 

Convert audit_log() call to WARN_ONCE().

Rename "type=" to nlmsg_type=" to avoid confusion with the audit record
type.

Added "protocol=" to help track down which protocol (NETLINK_AUDIT?) was used
within the netlink protocol family.

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
[Rewrote the patch subject line]
Signed-off-by: Paul Moore <pmoore@redhat.com>

Showing 1 changed file with 3 additions and 4 deletions Side-by-side Diff

security/selinux/hooks.c
Diff comments   View file @ e173fb2
... ... @@ -4727,10 +4727,9 @@
4727 4727 err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm);
4728 4728 if (err) {
4729 4729 if (err == -EINVAL) {
4730   - audit_log(current->audit_context, GFP_KERNEL, AUDIT_SELINUX_ERR,
4731   - "SELinux: unrecognized netlink message"
4732   - " type=%hu for sclass=%hu\n",
4733   - nlh->nlmsg_type, sksec->sclass);
  4730 + WARN_ONCE(1, "selinux_nlmsg_perm: unrecognized netlink message:"
  4731 + " protocol=%hu nlmsg_type=%hu sclass=%hu\n",
  4732 + sk->sk_protocol, nlh->nlmsg_type, sksec->sclass);
4734 4733 if (!selinux_enforcing || security_get_allow_unknown())
4735 4734 err = 0;
4736 4735 }