block: allow deleting zero length partition

delete_partition() was noop for zero length partition. As the addition code allows creating zero lenght partition and deletion is assumed to always succeed, this causes memory leak for zero length partitions. Allow zero length partitions to end their meaningless lives. While at it, allow deleting zero lenght partition via BLKPG_DEL_PARTITION ioctl too. Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

block: allow deleting zero length partition
delete_partition() was noop for zero length partition. As the addition code allows creating zero lenght partition and deletion is assumed to always succeed, this causes memory leak for zero length partitions. Allow zero length partitions to end their meaningless lives. While at it, allow deleting zero lenght partition via BLKPG_DEL_PARTITION ioctl too. Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Tejun Heo · Jens Axboe
1 parent def4e38ddd
Showing 2 changed files with 0 additions and 4 deletions Side-by-side Diff
block/ioctl.c
fs/partitions/check.c
@@ -68,8 +68,6 @@
 		case BLKPG_DEL_PARTITION:
 			if (!disk->part[part-1])
 				return -ENXIO;
-			if (disk->part[part - 1]->nr_sects == 0)
-				return -ENXIO;
 			bdevp = bdget_disk(disk, part);
 			if (!bdevp)
 				return -ENOMEM;
@@ -325,8 +325,6 @@
  
 	if (!p)
 		return;
-	if (!p->nr_sects)
-		return;
 	disk->part[part-1] = NULL;
 	p->start_sect = 0;
 	p->nr_sects = 0;
...	...	@@ -68,8 +68,6 @@
68	68	case BLKPG_DEL_PARTITION:
69	69	if (!disk->part[part-1])
70	70	return -ENXIO;
71		- if (disk->part[part - 1]->nr_sects == 0)
72		- return -ENXIO;
73	71	bdevp = bdget_disk(disk, part);
74	72	if (!bdevp)
75	73	return -ENOMEM;
...	...	@@ -325,8 +325,6 @@
325	325
326	326	if (!p)
327	327	return;
328		- if (!p->nr_sects)
329		- return;
330	328	disk->part[part-1] = NULL;
331	329	p->start_sect = 0;
332	330	p->nr_sects = 0;