Eric Lee / smarc-ti-linux-kernel | Embedian Git Server

Commit efc63c4fb0f95865907472d1c6bc0cfea9ee156b

Authored by Alexey Dobriyan 2007-09-19 13:46:27 +0800

Committed by Linus Torvalds 2007-09-20 02:24:17 +0800

Fix UTS corruption during clone(CLONE_NEWUTS)

struct utsname is copied from master one without any exclusion.

Here is sample output from one proggie doing

	sethostname("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
	sethostname("bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb");

and another

	clone(,, CLONE_NEWUTS, ...)
	uname()

	hostname = 'aaaaaaaaaaaaaaaaaaaaaaaaabbbbb'
	hostname = 'bbbaaaaaaaaaaaaaaaaaaaaaaaaaaa'
	hostname = 'aaaaaaaabbbbbbbbbbbbbbbbbbbbbb'
	hostname = 'aaaaaaaaaaaaaaaaaaaaaaaaaabbbb'
	hostname = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaabb'
	hostname = 'aaabbbbbbbbbbbbbbbbbbbbbbbbbbb'
	hostname = 'bbbbbbbbbbbbbbbbaaaaaaaaaaaaaa'

Hostname is sometimes corrupted.

Yes, even _the_ simplest namespace activity had bug in it. :-(

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff

kernel/utsname.c

kernel/utsname.c

Diff comments View file @ efc63c4

...	...	@@ -28,7 +28,9 @@
28	28	if (!ns)
29	29	return ERR_PTR(-ENOMEM);
30	30
	31	+ down_read(&uts_sem);
31	32	memcpy(&ns->name, &old_ns->name, sizeof(ns->name));
	33	+ up_read(&uts_sem);
32	34	kref_init(&ns->kref);
33	35	return ns;
34	36	}