Commit f0e4cba2534cd88476dff920727c81350130f3c5
1 parent
7d1311b93e
Exists in
ti-lsk-linux-4.1.y
and in
10 other branches
USB: option: reduce interrupt-urb logging verbosity
Do not log normal interrupt-urb shutdowns as errors. The option driver has always been logging any nonzero interrupt-urb status as an error, including when the urb is killed during normal operation. Commit 9096f1fbba91 ("USB: usb_wwan: fix potential NULL-deref at resume") moved the interrupt urb submission from port probe and release to open and close, thus potentially increasing the number of these false-positive error messages dramatically. Reported-by: Ed Butler <ressy66@ausics.net> Tested-by: Ed Butler <ressy66@ausics.net> Cc: <stable@vger.kernel.org> Signed-off-by: Johan Hovold <johan@kernel.org>
Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff
drivers/usb/serial/option.c
| ... | ... | @@ -1916,6 +1916,8 @@ |
| 1916 | 1916 | dev_dbg(dev, "%s: type %x req %x\n", __func__, |
| 1917 | 1917 | req_pkt->bRequestType, req_pkt->bRequest); |
| 1918 | 1918 | } |
| 1919 | + } else if (status == -ENOENT || status == -ESHUTDOWN) { | |
| 1920 | + dev_dbg(dev, "%s: urb stopped: %d\n", __func__, status); | |
| 1919 | 1921 | } else |
| 1920 | 1922 | dev_err(dev, "%s: error %d\n", __func__, status); |
| 1921 | 1923 |
