Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit f469ec9c5b95dfed60d5d628e1a8cecfc1f92d7a

Authored by Jan Kara
Committed by Fengguang Wu
1 parent 9f8050c4f9

fs: Remove bogus wait in write_inode_now() 

inode_sync_wait() in write_inode_now() is just bogus. That function waits for
I_SYNC bit to be cleared but writeback_single_inode() clears the bit on return
so the wait is effectivelly a nop unless someone else submits the inode for
writeback again. All the waiting write_inode_now() needs is achieved by using
WB_SYNC_ALL writeback mode.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Showing 1 changed file with 0 additions and 2 deletions Side-by-side Diff

... ... @@ -1364,8 +1364,6 @@
1364 1364 ret = writeback_single_inode(inode, wb, &wbc);
1365 1365 spin_unlock(&inode->i_lock);
1366 1366 spin_unlock(&wb->list_lock);
1367   - if (sync)
1368   - inode_sync_wait(inode);
1369 1367 return ret;
1370 1368 }
1371 1369 EXPORT_SYMBOL(write_inode_now);