Commit fa2b5ea09e48186041f68649ab8192447b31bffc

Authored by Linus Walleij
Committed by Greg Kroah-Hartman
1 parent 3592501054

serial: core: delete .set_wake() callback

This deletes the .set_wake() callback in the struct uart_ops.
Apparently this has been unused since pre-git times. In the
old-2.6-bkcvs it is deleted as part of a changeset removing
the PM_SET_WAKEUP from pm_request_t which is since also deleted
from the kernel.

The apropriate way to set wakeups in the kernel is to have a
code snippet like this in .suspend() or .runtime_suspend()
callbacks:

static int foo_suspend(struct device *dev)
{
	if (device_may_wakeup(dev)) {
		/* Enable wakeups, set internal states */
	}
}

This specific callback is not coming back.

Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Dmitry Artamonow <mad_soft@inbox.ru>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 2 changed files with 0 additions and 5 deletions Side-by-side Diff

Documentation/serial/driver
... ... @@ -264,10 +264,6 @@
264 264 Locking: none.
265 265 Interrupts: caller dependent.
266 266  
267   - set_wake(port,state)
268   - Enable/disable power management wakeup on serial activity. Not
269   - currently implemented.
270   -
271 267 type(port)
272 268 Return a pointer to a string constant describing the specified
273 269 port, or return NULL, in which case the string 'unknown' is
include/linux/serial_core.h
... ... @@ -66,7 +66,6 @@
66 66 void (*set_ldisc)(struct uart_port *, int new);
67 67 void (*pm)(struct uart_port *, unsigned int state,
68 68 unsigned int oldstate);
69   - int (*set_wake)(struct uart_port *, unsigned int state);
70 69  
71 70 /*
72 71 * Return a string describing the type of the port