Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit fb099cb712e878b9eb4e78dd6b268312a0b2b50f

Authored by Mark Brown
1 parent 15676937e6
Exists in master and in 20 other branches dlt-processor-sdk-linux-03.00.00.04, newt-ti-linux-3.12.y, processor-sdk-linux-01.00.00, processor-sdk-linux-02.00.01, smarc-ti-linux-3.12.10, smarc-ti-linux-3.12.y, smarc-ti-linux-3.14.y, smarc-ti-linux-3.15.y, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04, ti-linux-3.12.y, ti-linux-3.14.y, ti-linux-3.15.y, ti-lsk-linux-4.1.y

ASoC: core: Upgrade the severity of probe deferral errors to dev_err() 

In the past when ASoC had a custom probe deferral mechanism people
complained about the logspam it generated and didn't want to know about
the fact that we were doing probe deferral so all the error messages for
it were at dev_dbg(), making diagnostics hard. Now that we have probe
deferral as an accepted thing and it's generating log messages anyway
there's no need to worry about this so upgrade the severity of all the
probe deferral sources to dev_err() so that they are displayed by default.

Also add one for missing aux_devs since there wasn't one.

Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Showing 1 changed file with 6 additions and 4 deletions Side-by-side Diff

sound/soc/soc-core.c
Diff comments   View file @ fb099cb
... ... @@ -826,7 +826,7 @@
826 826 }
827 827  
828 828 if (!rtd->cpu_dai) {
829   - dev_dbg(card->dev, "CPU DAI %s not registered\n",
  829 + dev_err(card->dev, "CPU DAI %s not registered\n",
830 830 dai_link->cpu_dai_name);
831 831 return -EPROBE_DEFER;
832 832 }
833 833  
... ... @@ -857,14 +857,14 @@
857 857 }
858 858  
859 859 if (!rtd->codec_dai) {
860   - dev_dbg(card->dev, "CODEC DAI %s not registered\n",
  860 + dev_err(card->dev, "CODEC DAI %s not registered\n",
861 861 dai_link->codec_dai_name);
862 862 return -EPROBE_DEFER;
863 863 }
864 864 }
865 865  
866 866 if (!rtd->codec) {
867   - dev_dbg(card->dev, "CODEC %s not registered\n",
  867 + dev_err(card->dev, "CODEC %s not registered\n",
868 868 dai_link->codec_name);
869 869 return -EPROBE_DEFER;
870 870 }
... ... @@ -888,7 +888,7 @@
888 888 rtd->platform = platform;
889 889 }
890 890 if (!rtd->platform) {
891   - dev_dbg(card->dev, "platform %s not registered\n",
  891 + dev_err(card->dev, "platform %s not registered\n",
892 892 dai_link->platform_name);
893 893 return -EPROBE_DEFER;
894 894 }
... ... @@ -1480,6 +1480,8 @@
1480 1480 if (!strcmp(codec->name, aux_dev->codec_name))
1481 1481 return 0;
1482 1482 }
  1483 +
  1484 + dev_err(card->dev, "%s not registered\n", aux_dev->codec_name);
1483 1485  
1484 1486 return -EPROBE_DEFER;
1485 1487 }