Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit fce893a5e3f578f9f26a2718156057c84b397f12

Authored by Jiri Slaby
Committed by Greg Kroah-Hartman
1 parent 3bf7d03286
Exists in smarct4x-processor-sdk-linux-03.00.00.04 and in 2 other branches dlt-processor-sdk-linux-03.00.00.04, smarct3x-processor-sdk-linux-03.00.00.04

tty: vt, return error when con_startup fails 

commit 6798df4c5fe0a7e6d2065cf79649a794e5ba7114 upstream.

When csw->con_startup() fails in do_register_con_driver, we return no
error (i.e. 0). This was changed back in 2006 by commit 3e795de763.
Before that we used to return -ENODEV.

So fix the return value to be -ENODEV in that case again.

Fixes: 3e795de763 ("VT binding: Add binding/unbinding support for the VT console")
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: "Dan Carpenter" <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 3 additions and 2 deletions Side-by-side Diff

... ... @@ -3583,9 +3583,10 @@
3583 3583 goto err;
3584 3584  
3585 3585 desc = csw->con_startup();
3586   -
3587   - if (!desc)
  3586 + if (!desc) {
  3587 + retval = -ENODEV;
3588 3588 goto err;
  3589 + }
3589 3590  
3590 3591 retval = -EINVAL;
3591 3592