Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit fe956a1d4081ce1a959f87df397a15e252201f10

Authored by Aaro Koskinen
Committed by Benjamin Herrenschmidt
1 parent 3be7db6ab4
Exists in master and in 20 other branches dlt-processor-sdk-linux-03.00.00.04, newt-ti-linux-3.12.y, processor-sdk-linux-01.00.00, processor-sdk-linux-02.00.01, smarc-ti-linux-3.12.10, smarc-ti-linux-3.12.y, smarc-ti-linux-3.14.y, smarc-ti-linux-3.15.y, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04, ti-linux-3.12.y, ti-linux-3.14.y, ti-linux-3.15.y, ti-lsk-linux-4.1.y

powerpc/windfarm: Fix noisy slots-fan on Xserve (rm31) 

slots-fan on G5 Xserve is always running at full speed with windfarm_rm31
driver, resulting in a very high acoustic noise level. It seems the fan
parameters are incorrect, and have been copied from the Drive Bay fan
(RPM, not present on rm31) of the legacy therm_pm72 driver. This patch
changes the parameters to match the Slots fan (PWM) of therm_pm72. With
the patch, slots-fan speed drops from 99% to 19% during normal use,
and slots-temp settle to ~42'C.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
CC: <stable@vger.kernel.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Showing 1 changed file with 9 additions and 9 deletions Side-by-side Diff

drivers/macintosh/windfarm_rm31.c
Diff comments   View file @ fe956a1
... ... @@ -439,15 +439,15 @@
439 439  
440 440 /* Slots fan */
441 441 static const struct wf_pid_param slots_param = {
442   - .interval = 5,
443   - .history_len = 2,
444   - .gd = 30 << 20,
445   - .gp = 5 << 20,
446   - .gr = 0,
447   - .itarget = 40 << 16,
448   - .additive = 1,
449   - .min = 300,
450   - .max = 4000,
  442 + .interval = 1,
  443 + .history_len = 20,
  444 + .gd = 0,
  445 + .gp = 0,
  446 + .gr = 0x00100000,
  447 + .itarget = 3200000,
  448 + .additive = 0,
  449 + .min = 20,
  450 + .max = 100,
451 451 };
452 452  
453 453 static void slots_fan_tick(void)