21 Aug, 2006
1 commit
17 Aug, 2006
2 commits
-
__might_sleep+0x8e/0x93
acpi_os_wait_semaphore+0x50/0xa3
acpi_ut_acquire_mutex+0x28/0x6a
acpi_ns_get_node+0x46/0x88
acpi_ns_evaluate+0x2d/0xfc
acpi_rs_set_srs_method_data+0xc5/0xe1
acpi_set_current_resources+0x31/0x3f
acpi_pci_link_set+0xfc/0x1a5
irqrouter_resume+0x48/0x5fand
__might_sleep+0x8e/0x93
kmem_cache_alloc+0x2a/0x8f
acpi_evaluate_integer+0x32/0x96
acpi_bus_get_status+0x30/0x84
acpi_pci_link_set+0x12a/0x1a5
irqrouter_resume+0x48/0x5fhttp://bugzilla.kernel.org/show_bug.cgi?id=6810
Signed-off-by: Len Brown
-
While going through the code, I found out some memory leaks and potential
crashes in drivers/acpi/hotkey.c Please find the patch to fix them.This patch does the following,
1. Fixes memory leaks in error paths of hotkey_write_config
2. Fixes freeing unallocated pointers in the error paths of hotkey_write_config
3. Uses a loop instead of linear searching for parsing the userspace
input in get_params4. Uses array of char * instead of passing 4 pointer parameters
explicitly into the init_{poll_}hotkey_* static functionsSigned-off-by: Andrew Morton
Acked-by: Luming Yu
Signed-off-by: Len Brown
16 Aug, 2006
5 commits
-
This is to remove noisy useless message at boot. The message is a ton of
"ACPI Exception (acpi_memory-0492): AE_ERROR, handle is no memory device"In my emulation, number of memory devices are not so many (only 6), but,
this messages are displayed 114 times.It is showed by acpi_memory_register_notify_handler() which is called by
acpi_walk_namespace().acpi_walk_namespace() parses all of ACPI's namespace and execute
acpi_memory_register_notify_handler(). So, it is called for all of the
device which is defined in namespace. If the parsing device is not memory,
acpi_memhotplug ignores it due to "no match" and will parse next device.
This is normal route, not an exception.Signed-off-by: Yasunori Goto
Signed-off-by: Andrew Morton
Signed-off-by: Len Brown -
Signed-off-by: Randy Dunlap
Signed-off-by: Andrew Morton
Signed-off-by: Len Brown -
Signed-off-by: Randy Dunlap
Signed-off-by: Andrew Morton
Signed-off-by: Len Brown -
Signed-off-by: Len Brown
-
Fix acpi_ac/battery boot with acpi=off
Signed-off-by: Pavel Machek
Signed-off-by: Andrew Morton
Signed-off-by: Len Brown
12 Aug, 2006
1 commit
-
Signed-off-by: Jean Delvare
Signed-off-by: Len Brown
06 Aug, 2006
2 commits
-
both of acpi_memory_enable_device() and acpi_memory_add_device() may evaluate
_CRS method.We should avoid evaluate device's resource twice if we could get it
successfully in past.Signed-off-by: KAMEZWA Hiroyuki
Cc: Keith Mannthey
Cc: Yasunori Goto
Cc: Dave Hansen
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
add_memory() does all necessary check to avoid collision. then, acpi layer
doesn't have to check region by itself.(*) pfn_valid() just returns page struct is valid or not. It returns 0
if a section has been already added even is ioresource is not added.
ioresource collision check in mm/memory_hotplug.c can do more precise
collistion check.
added enabled bit check just for sanity check..Signed-off-by: KAMEZAWA Hiroyuki
Cc: Keith Mannthey
Cc: Yasunori Goto
Cc: Dave Hansen
Cc: "Brown, Len"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
04 Aug, 2006
1 commit
-
Remove uevent dock notifications. There are no consumers
of these events at present, and uevents are likely not the
correct way to send this type of event anyway.Until I get some kind of idea if anyone in userspace cares
about dock events, I will just not send any.Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Greg Kroah-Hartman
26 Jul, 2006
1 commit
-
The ACPI_EXCEPTION() patch enabled a bunch of messages to print
even in the non-DEBUG kernel. Need to change a couple back,
and note that ACPI_EXCEPTION takes no \n, but ACPI_DEBUG_PRINT does.No context for object [%p]\n
Device `[%s]' is not power manageable\nSigned-off-by: Len Brown
13 Jul, 2006
2 commits
-
This effectively reverts commit b8d35192c55fb055792ff0641408eaaec7c88988
by reverts acpi_os_queue_for_execution() to what it was before that,
except it changes the name to acpi_os_execute() to match ACPICA
20060512.Signed-off-by: Len Brown
[ The thread execution doesn't actually solve the bug it set out to
solve (seehttp://bugzilla.kernel.org/show_bug.cgi?id=5534
for more details) because the new events can get caught behind the AML
semaphore or other serialization. And when that happens, the notify
threads keep on piling up until the system dies. ]Signed-off-by: Linus Torvalds
-
Check and handle kset_register() and kobject_register() init errors.
Signed-off-by: Randy Dunlap
Signed-off-by: Len Brown
12 Jul, 2006
1 commit
-
Signed-off-by: Randy Dunlap
Signed-off-by: Len Brown
11 Jul, 2006
5 commits
-
* 'release' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6:
ACPI: ACPI_DOCK: Initialize the atomic notifier list
ACPI: acpi_os_allocate() fixes
ACPI: SBS: fix initialization, sem2mutex
ACPI: add 'const' to several ACPI file_operations
ACPI: delete some defaults from ACPI Kconfig
ACPI: "Device `[%s]' is not power manageable" make message debug only
ACPI: ACPI_DOCK Kconfig
Revert "Revert "ACPI: dock driver""
ACPI: acpi_os_get_thread_id() returns current
ACPI: ACPICA 20060707 -
No need for video to be always in
No need for smart battery driver to be always inAcked-by: Len Brown
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Andi Kleen
Signed-off-by: Linus Torvalds -
Daniel Ritz says:
The acpi driver suspend/resume patches that went in recently caused a regression
on my box (toshiba tecra 8000 laptop): after resume from swsusp the fan turns on
keeping blowing cold air out of my notebook. before the patches, the fan was off
and would only make noise when required. it's the same thing described in
bugzilla.kernel.org #5000. the acpi suspend/resume patches or at least parts of
them originate in this bug. now the last patch in the report (attach id 8438)
actually fixes the problem - for me and the reporter. this is a trimmed down
version of that patch.Signed-off-by: Daniel Ritz
Cc: Len Brown
Cc: Sanjoy Mahajan
Cc: Pavel Machek
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Signed-off-by: Kristen Carlson Accardi
Signed-off-by: Andrew Morton
Signed-off-by: Len Brown
10 Jul, 2006
14 commits
-
Replace acpi_in_resume with a more general hack
to check irqs_disabled() on any kmalloc() from ACPI.
While setting (system_state != SYSTEM_RUNNING) on resume
seemed more general, Andrew Morton preferred this approach.http://bugzilla.kernel.org/show_bug.cgi?id=3469
Make acpi_os_allocate() into an inline function to
allow /proc/slab_allocators to work.Delete some memset() that could fault on allocation failure.
Signed-off-by: Len Brown
-
cm_sbs_sem is being downed (via acpi_ac_init->acpi_lock_ac_dir) before it is
initialised, with grave results.- Make it a mutex
- Initialise it
- Make it static
- Clean other stuff up.
Thanks to Paul Drynoff for reporting and testing.
Cc: Rich Townsend
Signed-off-by: Andrew Morton
Signed-off-by: Len Brown -
Signed-off-by: Arjan van de Ven
Signed-off-by: Len Brown -
No need for video to be always in
No need for ACPI dock driver to be always in
No need for smart battery driver to be always inSigned-off-by: Andi Kleen
Signed-off-by: Len Brown -
Signed-off-by: Len Brown
-
HOTPLUG_PCI_ACPI depends on ACPI_DOCK
ACPI_IBM_DOCK depends on ACPI_DOCK=n
ACPI_DOCK is EXPERIMENTAL, though that doesn't seem to mean muchSigned-off-by: Len Brown
-
This reverts 953969ddf5b049361ed1e8471cc43dc4134d2a6f commit.
-
Linux mutexes and the debug code that that reference
acpi_os_get_thread_id() are happy with 0.
But the AML mutexes in exmutex.c expect a unique non-zero
number for each thread - as they track this thread_id
to permit the mutex re-entrancy defined by the ACPI spec.http://bugzilla.kernel.org/show_bug.cgi?id=6687
Signed-off-by: Len Brown
-
Added the ACPI_PACKED_POINTERS_NOT_SUPPORTED macro to
support C compilers that do not allow the initialization
of address pointers within packed structures - even though
the hardware itself may support misaligned transfers. Some
of the debug data structures are packed by default to
minimize size.Added an error message for the case where
acpi_os_get_thread_id() returns zero. A non-zero value is
required by the core ACPICA code to ensure the proper
operation of AML mutexes and recursive control methods.The DSDT is now the only ACPI table that determines whether
the AML interpreter is in 32-bit or 64-bit mode. Not really
a functional change, but the hooks for per-table 32/64
switching have been removed from the code. A clarification
to the ACPI specification is forthcoming in ACPI 3.0B.Fixed a possible leak of an Owner ID in the error
path of tbinstal.c acpi_tb_init_table_descriptor() and
migrated all table OwnerID deletion to a single place in
acpi_tb_uninstall_table() to correct possible leaks when using
the acpi_tb_delete_tables_by_type() interface (with assistance
from Lance Ortiz.)Fixed a problem with Serialized control methods where the
semaphore associated with the method could be over-signaled
after multiple method invocations.Fixed two issues with the locking of the internal
namespace data structure. Both the Unload() operator and
acpi_unload_table() interface now lock the namespace during
the namespace deletion associated with the table unload
(with assistance from Linn Crosetto.)Fixed problem reports (Valery Podrezov) integrated: -
Eliminate unnecessary memory allocation for CreateXxxxField
http://bugzilla.kernel.org/show_bug.cgi?id=5426Fixed problem reports (Fiodor Suietov) integrated: -
Incomplete cleanup branches in AcpiTbGetTableRsdt (BZ 369)
- On Address Space handler deletion, needless deactivation
call (BZ 374) - AcpiRemoveAddressSpaceHandler: validate
Device handle parameter (BZ 375) - Possible memory leak,
Notify sub-objects of Processor, Power, ThermalZone (BZ
376) - AcpiRemoveAddressSpaceHandler: validate Handler
parameter (BZ 378) - Minimum Length of RSDT should be
validated (BZ 379) - AcpiRemoveNotifyHandler: return
AE_NOT_EXIST if Processor Obj has no Handler (BZ (380)
- AcpiUnloadTable: return AE_NOT_EXIST if no table of
specified type loaded (BZ 381)Signed-off-by: Bob Moore
Signed-off-by: Len Brown
09 Jul, 2006
1 commit
-
This reverts commit a5e1b94008f2a96abf4a0c0371a55a56b320c13e.
Adrian Bunk points out that it has build errors, and apparently no
maintenance. Throw it out.Signed-off-by: Linus Torvalds
04 Jul, 2006
1 commit
-
* 'release' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6: (44 commits)
ACPI: remove function tracing macros from drivers/acpi/*.c
ACPI: add support for Smart Battery
ACPI: handle battery notify event on broken BIOS
ACPI: handle AC notify event on broken BIOS
ACPI: asus_acpi: add S1N WLED control
ACPI: asus_acpi: correct M6N/M6R display nodes
ACPI: asus_acpi: add S1N WLED control
ACPI: asus_acpi: rework model detection
ACPI: asus_acpi: support L5D
ACPI: asus_acpi: handle internal Bluetooth / support W5A
ACPI: asus_acpi: support A4G
ACPI: asus_acpi: support W3400N
ACPI: asus_acpi: LED display support
ACPI: asus_acpi: support A3G
ACPI: asus_acpi: misc cleanups
ACPI: video: Remove unneeded acpi_handle from driver.
ACPI: thermal: Remove unneeded acpi_handle from driver.
ACPI: power: Remove unneeded acpi_handle from driver.
ACPI: pci_root: Remove unneeded acpi_handle from driver.
ACPI: pci_link: Remove unneeded acpi_handle from driver.
...
03 Jul, 2006
1 commit
-
Signed-off-by: Thomas Gleixner
Cc: Ingo Molnar
Cc: "David S. Miller"
Cc: Benjamin Herrenschmidt
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
02 Jul, 2006
2 commits