27 Aug, 2006

1 commit

  • This patch contains 2 sets of fixes for the abituguru:
    1) Much improved timeout handling, drasticly reducing the amount of
    timeout errors on some motherboards
    2) Fix the exit paths in the bank1 sensor type detect code to always
    restore the original settings even on an error. Without this our
    special test settings could remain seriously confusing the system
    BIOS's setup menu.

    Both are very much related and are must haves, to avoid messing up the
    uguru CMOS settings.

    Detailed changes:
    - Much improved timeout / wait for status handling. Many thanks to Sunil
    Kumar, for all his testing, ideas and patches! The code now first busy
    waits, polling the uguru for the expected status as this usually
    succeeds pretty quickly (within 90 reads). To avoid unnecessary CPU burn
    in timeout conditions, the amount of busy waiting has been halved from
    previous versions (120 tries instead of 250). This is not a problem,
    because this version goes to sleep after 120 attemps for 1 jiffy and
    then tries again, it does this sleep and try again 5 times before
    finally giving up. This (almost?) completly removes the timeout errors
    some people have seen regulary. Apparently some older uguru versions
    sometimes are distracted for a (relatively) long time. This solves this.
    - These timeout errors not only occur in the sending address part of
    reading the uguru but also in the wait for read state, so errors in
    this state are now handled as retryable just like send address state
    errors and are only logged and reported to userspace if 3 executive
    tries fail.
    - Fix a very nasty bug in the bank1 sensor type detection code, where it
    would not restore the original settings in any of the error paths!
    - Since not successfully restoring the original settings can seriously
    confuse the system BIOS (hang when entering the relevant setup menu),
    we now try restoring them 3 times before giving up.

    Signed-off-by: Hans de Goede
    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Hans de Goede
     

13 Jul, 2006

1 commit

  • Now that the abituguru driver is seeing some more widespread testing
    it has turned out that one the first generation of Abit uGuru
    motherboards, with uGuru revision 1, the autodetect bank1 sensor type
    code doesn't (always) work. This patch adds a module param to override
    the autodetect, and it adds validity checks for the value of the 2
    other autodetection override module params. An example of howto use
    the new param can be found here:
    http://lm-sensors.org/wiki/Configurations/Abit/AN7

    Signed-off-by: Hans de Goede
    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Hans de Goede
     

01 Jul, 2006

1 commit


27 Jun, 2006

1 commit

  • acquired (aquired)
    contiguous (contigious)
    successful (succesful, succesfull)
    surprise (suprise)
    whether (weather)
    some other misspellings

    Signed-off-by: Andreas Mohr
    Signed-off-by: Adrian Bunk

    Andreas Mohr
     

23 Jun, 2006

18 commits


15 Apr, 2006

1 commit


11 Apr, 2006

3 commits


03 Apr, 2006

1 commit

  • This reverts the mutex conversion that was recently done to the hdaps
    driver; this coversion was buggy because the hdaps driver started using
    this semaphore in IRQ context, which mutexes do not allow. Easiest
    solution for now is to just revert the patch (the patch was part of a
    bigger GIT commit, 9a61bf6300533d3b64d7ff29adfec00e596de67d but this
    only reverts this one file)

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

24 Mar, 2006

13 commits