27 Aug, 2006
1 commit
-
This patch contains 2 sets of fixes for the abituguru:
1) Much improved timeout handling, drasticly reducing the amount of
timeout errors on some motherboards
2) Fix the exit paths in the bank1 sensor type detect code to always
restore the original settings even on an error. Without this our
special test settings could remain seriously confusing the system
BIOS's setup menu.Both are very much related and are must haves, to avoid messing up the
uguru CMOS settings.Detailed changes:
- Much improved timeout / wait for status handling. Many thanks to Sunil
Kumar, for all his testing, ideas and patches! The code now first busy
waits, polling the uguru for the expected status as this usually
succeeds pretty quickly (within 90 reads). To avoid unnecessary CPU burn
in timeout conditions, the amount of busy waiting has been halved from
previous versions (120 tries instead of 250). This is not a problem,
because this version goes to sleep after 120 attemps for 1 jiffy and
then tries again, it does this sleep and try again 5 times before
finally giving up. This (almost?) completly removes the timeout errors
some people have seen regulary. Apparently some older uguru versions
sometimes are distracted for a (relatively) long time. This solves this.
- These timeout errors not only occur in the sending address part of
reading the uguru but also in the wait for read state, so errors in
this state are now handled as retryable just like send address state
errors and are only logged and reported to userspace if 3 executive
tries fail.
- Fix a very nasty bug in the bank1 sensor type detection code, where it
would not restore the original settings in any of the error paths!
- Since not successfully restoring the original settings can seriously
confuse the system BIOS (hang when entering the relevant setup menu),
we now try restoring them 3 times before giving up.Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
13 Jul, 2006
1 commit
-
Now that the abituguru driver is seeing some more widespread testing
it has turned out that one the first generation of Abit uGuru
motherboards, with uGuru revision 1, the autodetect bank1 sensor type
code doesn't (always) work. This patch adds a module param to override
the autodetect, and it adds validity checks for the value of the 2
other autodetection override module params. An example of howto use
the new param can be found here:
http://lm-sensors.org/wiki/Configurations/Abit/AN7Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
01 Jul, 2006
1 commit
-
Signed-off-by: Jörn Engel
Signed-off-by: Adrian Bunk
27 Jun, 2006
1 commit
-
acquired (aquired)
contiguous (contigious)
successful (succesful, succesfull)
surprise (suprise)
whether (weather)
some other misspellingsSigned-off-by: Andreas Mohr
Signed-off-by: Adrian Bunk
23 Jun, 2006
18 commits
-
This patch adds support for two new VID codes, supporting Intel mobile Core
processors and new Conroe based platforms.Signed-off-by: Rudolf Marek
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
This driver implements support for the National Semiconductor LM70
temperature sensor.The LM70 temperature sensor chip supports a single temperature sensor.
It communicates with a host processor (or microcontroller) via an
SPI/Microwire Bus interface.Communication with the LM70 is simple: when the temperature is to be sensed,
the driver accesses the LM70 using SPI communication: 16 SCLK cycles
comprise the MOSI/MISO loop. At the end of the transfer, the 11-bit 2's
complement digital temperature (sent via the SIO line), is available in the
driver for interpretation. This driver makes use of the kernel's in-core
SPI support.Signed-off-by: Kaiwan N Billimoria
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Hardware monitoring chips don't have to be on the I2C bus.
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
One of my testers had a problem where the driver only saw 2 of the 4 fan
sensors his uGuru has, this fixes this.
-accept 0x40 (bit 6) being high as a valid fan sensor setting for all fans
not just fan 1, I have a feeling this bit indicates whether or not a fan is
actually connected .Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Fixes to the Abit uGuru driver as requested in review by Jean Delvare:
- exactly calculate the sysfs_names array length using macro
- use snprintf when generating names to double check that the sysfs_names
array does not overflow.
- use ARRAY_SIZE and / or defines to determine number of loops in for loops
instead of using hardcoded values.
- In abituguru_probe(), refactor the error path leaving a single call to kfreeSigned-off-by: Hans de Goede
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
New hardware monitoring driver for the Abit uGuru
Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Add missing data lock in w83792d driver to avoid unexpected
data change.Signed-off-by: Yuan Mu
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
W83792D use pwm register low 4 bits to store PWM/DC value, bit 7
is used to store fan PWM/DC mode. The store_pwm function did not
convert the pwm input correctly, so it may change the fan mode
when new value is set.This fix the problem. Change the "index" value of pwm*_mode
and pwm* SENSOR_ATTR to simplify code.Signed-off-by: Yuan Mu
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Fix a typo in the hdaps driver.
Signed-off-by: Jean Delvare
Acked-by: Robert Love
Signed-off-by: Greg Kroah-Hartman -
Following patch trims the VID value to correct number of bits
for each VRM.Signed-off-by: Rudolf Marek
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Improve the help text for CONFIG_HWMON to let the users know how they
pick the right hardware monitoring driver(s) for their system.Also fix a couple typos in the related documentation file and improve
some parts a bit.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Add support for the w83791d sensor chip. The w83791d hardware is
somewhere between the w83781d and the w83792d and this driver code
is derived from the code that supports those chips.Signed-off-by: Charles Spirakis
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Update the list of systems supported by the hdaps driver:
* Add the "ThinkPad Z60m" entry, reported by Arkadiusz Miskiewicz.
* Add the "ThinkPad H" entry, reported by Frank Gevaerts for some
ThinkPad R52 models (1846AQG).
* Drop the "ThinkPad X41 Tablet" entry, which looks redundant to me.
And a comment update for good measure.Signed-off-by: Jean Delvare
Cc: Arkadiusz Miskiewicz
Cc: Frank Gevaerts
Signed-off-by: Greg Kroah-Hartman -
The F71805F I/O resource structure needs not be a global variable,
as the platform core allocs its own copy of it anyway.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
New driver (smsc47m192) which supports voltage and temperature
measurement features of SMSC LPC47M192 and LPC47M997 chips.Signed-off-by: Hartmut Rick
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Add alarms support for the W83627EHF/EHG hardware monitoring chip.
This is based on an earlier patch from Rudolf Marek.
Signed-off-by: Rudolf Marek
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Add the voltage measuring support to W83627EHF. The code is based
on the patch provided by Yuan Mu from Winbond.Signed-off-by: Yuan Mu
Signed-off-by: Rudolf Marek
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Add LM82 temperature sensor support (similar to the LM83,
but less featureful).Signed-off-by: Jordan Crouse
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
15 Apr, 2006
1 commit
-
Make the w83792d driver keep quiet when misdetecting a chip. This can
happen, and the user doesn't need to know.Also renumber the messages, and add one, for consistency.
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
11 Apr, 2006
3 commits
-
Use ENODEV when the hdaps hardware isn't there, not ENXIO.
Cc: Jean Delvare
Cc: Robert Love
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Add support for forthcoming Lenovo-branded machines to the HDAPS driver.
Signed-off-by: Robert Love
Cc: Jean Delvare
Cc: Dmitry Torokhov
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
This adds support for my Thinkpad R52, which for some reason is not matched
by the "ThinkPad R52" line.Signed-off-by: Frank Gevaerts
Cc: Robert Love
Cc: Dmitry Torokhov
Cc: Greg KH
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
03 Apr, 2006
1 commit
-
This reverts the mutex conversion that was recently done to the hdaps
driver; this coversion was buggy because the hdaps driver started using
this semaphore in IRQ context, which mutexes do not allow. Easiest
solution for now is to just revert the patch (the patch was part of a
bigger GIT commit, 9a61bf6300533d3b64d7ff29adfec00e596de67d but this
only reverts this one file)Signed-off-by: Arjan van de Ven
Signed-off-by: Linus Torvalds
24 Mar, 2006
13 commits
-
Signed-off-by: Alexey Dobriyan
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Add required locking around idr_ routines, retry the idr_pre_get/idr_get_new
pair properly, and sprinkle in some likely/unlikely for good measure.(Lack of idr locking didn't hurt when all callers were I2C clients, as the
i2c-core serialized for us anyway. Now that we have non I2C hwmon drivers,
this is truly necessary.)Signed-off-by: Mark M. Hoffman
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
"register" is a reserved keyword so using it as a parameter name
can confuse some compilers, most notably ICC.The patch below just renames all occurences to reg which fits the actual
function declarations.Signed-off-by: Darren Jenkins
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Stop resetting the chip on load by default, so as to preserve the BIOS
initializations. Same was done in the w83627hf driver some times ago
for the same reasons.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Use dynamic sysfs callbacks and array of attributes to reduce the
w83627ehf driver size.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Add support for the Intel Pentium M series to the hwmon-vid driver.
Signed-off-by: Jean Delvare
Cc: Rudolf Marek
Signed-off-by: Greg Kroah-Hartman -
Add support for the Winbond W83687THF chip to the w83627hf hardware
monitoring driver. This new chip is almost similar to the already
supported W83627THF chip, except for VID and a few other minor
changes.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Convert the new f71805f hardware monitoring driver to use mutexes
instead of semaphores.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
convert drivers/hwmon/*.c semaphore use to mutexes.
the conversion was generated via scripts, and the result was validated
automatically via a script as well.all affected hwmon drivers were build-tested.
Signed-off-by: Ingo Molnar
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Drop 3 useless macros in the w83792d hardware monitoring driver.
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Use arrays of attributes in the w83792d driver.
Signed-off-by: Jim Cromie
Signed-off-by: Yuan Mu
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Convert the f71805f driver to use arrays of attributes. This shrinks the
compiled module from 12.0 kB to 9.6 kB. We certainly should do the same
for as many hardware monitoring drivers as possible.This, together with a nice chip design by Fintek, makes this driver
very small, both in terms of number of lines of code and memory
consumption.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Convert individual sensors to sensor-attr arrays by each sensor type,
and initialize them in loops instead of long blocks of individual calls.Signed-off-by: Jim Cromie
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman