25 Sep, 2006
27 commits
-
With this, we don't need to pass an additional struct with function pointer.
Now that the callbacks are fully used, comment the remaining API.
Signed-off-by: Mark Fasheh
-
Have ocfs2_process_blocked_lock() call ocfs2_generic_unblock_lock(), which
gets to be ocfs2_unblock_lock() now that it's the only possible unblock
function.Remove the ->unblock() callback from the structure, and all lock type
specific unblock functions.Signed-off-by: Mark Fasheh
-
This way lock types don't have to manually pass it to
ocfs2_generic_unblock_lock().Signed-off-by: Mark Fasheh
-
The meta data unblocking code no longer needs ocfs2_do_unblock_meta() or
ocfs2_can_downconvert_meta_lock(), so remove them.Signed-off-by: Mark Fasheh
-
Fill in the ->check_downconvert and ->set_lvb callbacks with meta data
specific operations and switch ocfs2_unblock_meta() to call
ocfs2_generic_unblock_lock()Signed-off-by: Mark Fasheh
-
This allows a lock type to set the value block before downconvert.
Signed-off-by: Mark Fasheh
-
This will allow lock types to force a requeue of a lock downconvert.
Signed-off-by: Mark Fasheh
-
Tidy up the exit path a bit too.
Signed-off-by: Mark Fasheh
-
Allow a lock type to specifiy whether it makes use of the LVB. The only type
which does this right now is the meta data lock. This should save us some
space on network messages since they won't have to needlessly transmit value
blocks.Signed-off-by: Mark Fasheh
-
There is extremely little difference between the two now. We can remove the
callback from ocfs2_lock_res_ops as well.Signed-off-by: Mark Fasheh
-
Will be used to find the ocfs2_super structure from a given lockres.
Signed-off-by: Mark Fasheh
-
This was always defined to the same function in all locks, so clean things
up by removing and passing ocfs2_unlock_ast() directly to the DLM.Signed-off-by: Mark Fasheh
-
There is extremely little difference between the two now. We can remove the
callback from ocfs2_lock_res_ops as well.Signed-off-by: Mark Fasheh
-
Use of the refresh mechanism is lock-type wide, so move knowledge of that to
the ocfs2_lock_res_ops structure.Signed-off-by: Mark Fasheh
-
OCFS2 puts inode meta data in the "lock value block" provided by the DLM.
Typically, i_generation is encoded in the lock name so that a deleted inode
on and a new one in the same block don't share the same lvb.Unfortunately, that scheme means that the read in ocfs2_read_locked_inode()
is potentially thrown away as soon as the meta data lock is taken - we
cannot encode the lock name without first knowing i_generation, which
requires a disk read.This patch encodes i_generation in the inode meta data lvb, and removes the
value from the inode meta data lock name. This way, the read can be covered
by a lock, and at the same time we can distinguish between an up to date and
a stale LVB.This will help cold-cache stat(2) performance in particular.
Since this patch changes the protocol version, we take the opportunity to do
a minor re-organization of two of the LVB fields.Signed-off-by: Mark Fasheh
-
When i_generation is removed from the lockname, this will help us determine
whether a meta data lvb has information that is in sync with the local
struct inode.Signed-off-by: Mark Fasheh
-
lvb_version doesn't need to be a whole 32 bits. Make it an 8 bit field to
free up some space. This should be backwards compatible until we use one of
the fields, in which case we'd bump the lvb version anyway.Signed-off-by: Mark Fasheh
-
We can't use LKM_LOCAL for new dentry locks because an unlink and subsequent
re-create of a name/inode pair may result in the lock still being mastered
somewhere in the cluster.Signed-off-by: Mark Fasheh
-
Make use of FS_RENAME_DOES_D_MOVE to avoid a race condition that can occur
during ->rename() if we d_move() outside of the parent directory cluster
locks, and another node discovers the new name (created during the rename)
and unlinks it. d_move() will unconditionally rehash a dentry - which will
leave stale data in the system.Signed-off-by: Mark Fasheh
-
This is unused now.
Signed-off-by: Mark Fasheh
-
Actually replace the vote calls with the new dentry operations. Make any
necessary adjustments to get the scheme to work.Signed-off-by: Mark Fasheh
-
Replace the dentry vote mechanism with a cluster lock which covers a set
of dentries. This allows us to force d_delete() only on nodes which actually
care about an unlink.Every node that does a ->lookup() gets a read only lock on the dentry, until
an unlink during which the unlinking node, will request an exclusive lock,
forcing the other nodes who care about that dentry to d_delete() it. The
effect is that we retain a very lightweight ->d_revalidate(), and at the
same time get to make large improvements to the average case performance of
the ocfs2 unlink and rename operations.This patch adds the higher level API and the dentry manipulation code.
Signed-off-by: Mark Fasheh
-
Replace the dentry vote mechanism with a cluster lock which covers a set
of dentries. This allows us to force d_delete() only on nodes which actually
care about an unlink.Every node that does a ->lookup() gets a read only lock on the dentry, until
an unlink during which the unlinking node, will request an exclusive lock,
forcing the other nodes who care about that dentry to d_delete() it. The
effect is that we retain a very lightweight ->d_revalidate(), and at the
same time get to make large improvements to the average case performance of
the ocfs2 unlink and rename operations.This patch adds the cluster lock type which OCFS2 can attach to
dentries. A small number of fs/ocfs2/dcache.c functions are stubbed
out so that this change can compile.Signed-off-by: Mark Fasheh
-
File system lock names are very regular right now, so we really only need to
pass an extra parameter to dlmlock().Signed-off-by: Mark Fasheh
-
We just need to add a namelen field to the user_lock_res structure, and
update a few debug prints. Instead of updating all debug prints, I took the
opportunity to remove a few that are likely unnecessary these days.Signed-off-by: Mark Fasheh
-
The OCFS2 DLM uses strlen() to determine lock name length, which excludes
the possibility of putting binary values in the name string. Fix this by
requiring that string length be passed in as a parameter.Signed-off-by: Mark Fasheh
-
An AST can be delivered via the network after a lock has been removed, so no
need to print an error when we see that.Signed-off-by: Mark Fasheh
21 Sep, 2006
9 commits
-
The truncate code was never supposed to BUG() on an allocator it doesn't
know about, but rather to ignore it. Right now, this does nothing, but when
we change our allocation paths to use all suballocator files, this will
allow current versions of the fs module to work fine.Signed-off-by: Mark Fasheh
-
Signed-off-by: Mark Fasheh
-
Uptodate.c now knows about read-ahead buffers. Use some more aggressive
logic in ocfs2_readdir().The two functions which currently use directory read-ahead are
ocfs2_find_entry() and ocfs2_readdir().Signed-off-by: Mark Fasheh
-
We weren't always updating i_mtime on writes, so fix ocfs2_commit_write() to
handle this.Signed-off-by: Mark Fasheh
Acked-by: Zach Brown -
Remove the redundant "i_nlink >= OCFS2_LINK_MAX" check and adds an unlinked
directory check in ocfs2_link().Signed-off-by: Tiger Yang
Signed-off-by: Mark Fasheh -
The dir nlink check in ocfs2_mknod() was being done outside of the cluster
lock, which means we could have been checking against a stale version of the
inode. Fix this by doing the check after the cluster lock instead.Signed-off-by: Mark Fasheh
-
This fixes things for devices which set max_sectors to 8.
Signed-off-by: Mark Fasheh
-
Every file should #include the headers containing the prototypes for its
global functions.Signed-off-by: Adrian Bunk
Signed-off-by: Mark Fasheh -
Support immutable, and other attributes.
Some renaming and other minor fixes done by myself.
Signed-off-by: Herbert Poetzl
Signed-off-by: Mark Fasheh
08 Aug, 2006
4 commits
-
Record the most recently used allocation group on the allocation context, so
that subsequent allocations can attempt to optimize for contiguousness.
Local alloc especially should benefit from this as the current chain search
tends to let it spew across the disk.Signed-off-by: Mark Fasheh
-
Try to catch corrupted group descriptors with some stronger checks placed in
a couple of strategic locations. Detect a failed resizefs and refuse to
allocate past what bitmap i_clusters allows.Signed-off-by: Mark Fasheh
-
We were storing cluster count on the ocfs2_super structure, but never
actually using it so remove that. Also, we don't want to populate the
uptodate cache with the unlocked block read - it is technically safe as is,
but we should change it for correctness.Signed-off-by: Mark Fasheh
-
This patch removes the unused EXPORT_SYMBOL_GPL(dlm_migrate_lockres).
Signed-off-by: Adrian Bunk
Signed-off-by: Mark Fasheh