22 Dec, 2008
1 commit
-
xfs_fs_vcmn_err can be called under a spinlock, but does a sleeping memory
allocation to create buffer for it's internal sprintf. Fortunately it's
the only caller of icmn_err, so we can merge the two and have one single
static buffer and spinlock protecting it. While we're at it make sure
we proper __attribute__ format annotations so that the compiler can detect
mismatched format strings.Reported-by: Alexander Beregalov
Signed-off-by: Christoph Hellwig
Reviewed-by: Eric Sandeen
Signed-off-by: Lachlan McIlroy
13 Aug, 2008
1 commit
-
All the error injection is already enabled through ifdef DEBUG, so kill
the never set second cpp symbol to activate it without the rest of the
debugging infrastructure.SGI-PV: 981498
SGI-Modid: xfs-linux-melb:xfs-kern:31771a
Signed-off-by: Christoph Hellwig
Signed-off-by: Niv Sardi
Signed-off-by: Lachlan McIlroy
28 Jul, 2008
1 commit
-
Currently the xfs module init/exit code is a mess. It's farmed out over a
lot of function with very little error checking. This patch makes sure we
propagate all initialization failures properly and clean up after them.
Various runtime initializations are replaced with compile-time
initializations where possible to make this easier. The exit path is
similarly consolidated.There's now split out function to create/destroy the kmem zones and
alloc/free the trace buffers. I've also changed the ktrace allocations to
KM_MAYFAIL and handled errors resulting from that.And yes, we really should replace the XFS_*_TRACE ifdefs with a single
XFS_TRACE..SGI-PV: 976035
SGI-Modid: xfs-linux-melb:xfs-kern:31354a
Signed-off-by: Christoph Hellwig
Signed-off-by: Niv Sardi
Signed-off-by: Lachlan McIlroy
07 Feb, 2008
1 commit
-
No need for xfs to have its own hex dumping routine now that the kernel
has one.SGI-PV: 971186
SGI-Modid: xfs-linux-melb:xfs-kern:29847aSigned-off-by: Eric Sandeen
Signed-off-by: Lachlan McIlroy
Signed-off-by: Tim Shimmin
16 Oct, 2007
1 commit
-
vfs_altfsid was just a pointer to mp->m_fixedfsid so we can trivially
replace it with the latter. vfs_fsid also was identical to m_fixedfsid
through rather obfuscated ways so we can kill it as well and simply its
only user.SGI-PV: 969608
SGI-Modid: xfs-linux-melb:xfs-kern:29506aSigned-off-by: Christoph Hellwig
Signed-off-by: David Chinner
Signed-off-by: Tim Shimmin