09 Jul, 2011
3 commits
-
It's harmless but annyoing.
sound/pci/hda/patch_realtek.c: In function ‘alc_cap_getput_caller’:
sound/pci/hda/patch_realtek.c:2722:9: warning: ‘err’ may be used uninitialized in this functionSigned-off-by: Takashi Iwai
-
…sound-2.6 into fix/asoc
08 Jul, 2011
1 commit
-
mask didn't cover update-data
Signed-off-by: Kuninori Morimoto
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
Cc: stable@kernel.org
07 Jul, 2011
1 commit
-
When the dual-adc switching mode is active in Realtek auto-parser,
we need to couple all ADCs as a single capture-volume. Currently, the
volume control changes only the first ADC, thus others may remain silent.
This patch fixes the problem.Signed-off-by: Takashi Iwai
06 Jul, 2011
1 commit
-
Now we have supply widgets there's no need to open code the handling of
the ACTIVE bit.Signed-off-by: Mark Brown
Tested-by: Nicolas Ferre
Acked-by: Liam Girdwood
05 Jul, 2011
3 commits
-
The snd_card->driver field contains a driver name string, and in
general it shouldn't contain space or special letters. The commit
2b39535b9e54888649923beaab443af212b6c0fd changed the string copy from
card->name, but the long name string may contain such letters, thus
it may still lead to a segfault.A temporary fix is not to copy the long name string but just keep it
empty as the earlier version did.Reported-by: Kuninori Morimoto
Acked-by: Liam Girdwood
Signed-off-by: Takashi Iwai -
…sound-2.6 into fix/asoc
04 Jul, 2011
2 commits
-
This delay is very conservative.
Signed-off-by: Mark Brown
Acked-by: Liam Girdwood
Cc: stable@kernel.org -
The I2S controller needs a clock to respond to register writes. Without
this, register writes will at worst hang the CPU. In practice, I've only
observed writes being dropped.Luckily, the dropped register writes historically had no effect:
TEGRA_I2S_TIMING: The value we wrote was the reset default.
TEGRA_I2S_FIFO_SCR: The default was for the FIFOs to request more data
when one slot was empty. The requested value was for the FIFOs to request
when four slots were empty. The DMA controller in the mainline kernel is
configured to burst a single entry at a time into the FIFO, hence there
was no issue. The only negative effect was on bus efficiency losses due
to an increased number of arbitration attempts.However, in various non-upstream changes, the DMA controller now bursts
four entries at a time into the FIFO. If there is only space for one
entry, the data is simply dropped. In practice, this resulted in 3/4 of
samples being dropped, and playback at 4x the expected rate and pitch.
By fixing the clocking issue, this is solved.Signed-off-by: Stephen Warren
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
30 Jun, 2011
3 commits
-
The char can be unsigned on some architectures. Since the code checks
the negative values, they should be declared as signed char explicitly.sound/pci/rme9652/hdspm.c:5449: warning: comparison is always false due to limited range of data type
sound/pci/rme9652/hdspm.c:5462: warning: comparison is always false due to limited range of data typeSigned-off-by: Takashi Iwai
-
Fix the wrongly converted short values:
sound/pci/cs5535audio/cs5535audio_pcm.c:152: warning: large integer implicitly truncated to unsigned type
sound/pci/cs5535audio/cs5535audio_pcm.c:160: warning: large integer implicitly truncated to unsigned typeSigned-off-by: Takashi Iwai
-
The Blackfin DMA controller can report one frame beyond the end of the
buffer in the wraparound case but ALSA requires that the pointer always
be in the buffer. Do the wraparound to handle this. A similar bug is
likely to apply to the other Blackfin PCM drivers but the code is less
obvious to inspection and I don't have a user to test.Reported-by: Kieran O'Leary
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
Cc: stable@kernel.org
29 Jun, 2011
1 commit
-
I noticed that the last character of the ELD monitor name is lost,
this fixes the issue.This fix should be confirming to the HDA spec, and works together with
the DRM part of the ELD patch.The HDA spec does not mention that Monitor_Name_String is an '\0'
ending string, and it allows NML to be 1, which is only valid when MNL
does not count the possible ending '\0'.Signed-off-by: Wu Fengguang
Signed-off-by: Takashi Iwai
28 Jun, 2011
3 commits
-
This patch updates the email address of the sound drivers supported by me to an
email account I will use on a more regular basis in the future.Signed-off-by: Hans-Christian Egtvedt
Signed-off-by: Takashi Iwai -
Since we're not using the new auto parser as a fallback yet,
add it manually as a quirk.Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
Conexant ID 506c was found on Acer Aspire 3830TG. As users report
no playback, sending to stable should be safe.Cc: stable@kernel.org
BugLink: https://bugs.launchpad.net/bugs/783582
Reported-by: andROOM
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
24 Jun, 2011
5 commits
-
In the sound/ directory there are two files (flagged by 'make
versioncheck'); sound/pci/asihpi/asihpi.c and
sound/soc/codecs/wm8991.c that include linux/version.h although they
don't need it. This patch removes the unneeded includes.Signed-off-by: Jesper Juhl
Signed-off-by: Takashi Iwai -
Don't rely on the codec's channels_min information to decide wheter or
not allocate a substream's DMA buffer. Rather check if the substream
itself was allocated previously.Signed-off-by: Daniel Mack
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
Cc: stable@kernel.org -
- add some modules aliases
- add module license to avoid tainted kernel when loading the imx-pcm-audio
driverSigned-off-by: Arnaud Patard
Acked-by: Sascha Hauer
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown -
SND_MXC_SOC_SSI looks to be unused, so kill it.
Signed-off-by: Arnaud Patard
Acked-by: Sascha Hauer
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
23 Jun, 2011
1 commit
-
BIOS lists the internal speaker as an internal line-out. Change to
internal speaker + model=auto for better auto-mute capabilities.BugLink: http://bugs.launchpad.net/bugs/754964
Reported-by: Marc Legris
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
21 Jun, 2011
4 commits
-
Create a master volume and mute control of playback for VT1718S.
Signed-off-by: Lydia Wang
Signed-off-by: Takashi Iwai -
When switch HP independent mode, mute/unmute connctions of mixer which is
connected to headphone for VT1718S.Signed-off-by: Lydia Wang
Signed-off-by: Takashi Iwai -
Remove some invalid initial verbs and correct some wrong initial verbs
for VT1718S codec.Signed-off-by: Lydia Wang
Signed-off-by: Takashi Iwai -
The "diverse" Quanta ID 0x0763 is overridden to ALC268_ACER.
This keeps headphone automute and microphone input from operating
on at least one laptop from Opti Systems.
Without the override, the BIOS parser does a fine job setting the
card up and everything works.Tested-By: Peter Schneider
Signed-off-by: Tony Vroon
Signed-off-by: Takashi Iwai
20 Jun, 2011
1 commit
-
The reporter, who is running kernel 2.6.38, reports that
he needs to set model=auto for the headphone output to work
correctly.BugLink: http://bugs.launchpad.net/bugs/761022
Cc: stable@kernel.org (v2.6.38+)
Reported-by: Jo
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
17 Jun, 2011
3 commits
-
The via driver spews warnigs like
hda-codec: no NID for mapping control Independent HP:0:0
with some codecs because snd_hda_add_nid() is called with nid=0.
This patch fixes it by skipping the call when no corresponding widget
is found.Signed-off-by: Takashi Iwai
-
Since commit 13882a82ee16 (optimize iso queueing by setting
wake only after the last packet), drivers are required to call
fw_iso_context_queue_flush() after queueing a batch of packets.
The missing call would have an effect only if the controller
queue underruns, but then the DMA would stop completely.Signed-off-by: Clemens Ladisch
Signed-off-by: Takashi Iwai -
Fixed remaining issues of the signedness bug discovered by Dan Carpenter.
A check was remaining that tests if unsigned rt->rate is >= 0.
Changed that so that rt->rate now consistently uses ARRAY_SIZE(rates)
as invalid rate value and not -1.Signed-off-by: Torsten Schenk
Signed-off-by: Takashi Iwai
15 Jun, 2011
1 commit
-
Add missing __devinit.
Signed-off-by: Takashi Iwai
14 Jun, 2011
3 commits
-
The commit 2308f4add3de9f6c9c9f02e49461e94d84bb200a missed static inline
thus it resulted in multiple-definitions error at linking.Signed-off-by: Takashi Iwai
-
We have a double-free bug in
sound/usb/6fire/firmware.c::usb6fire_fw_ezusb_upload().
We already call release_firmware(fw) on line 258, so when we then do it
again after usb6fire_fw_ezusb_write() returns
Signed-off-by: Takashi Iwai -
This will be removed in -next so let's drop it from mainline as soon as
we can in order to minimise surprises.Signed-off-by: Mark Brown
13 Jun, 2011
4 commits
-
Using static inline functions can reduce compilation messages
and macro misuse.sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5045’:
sound/pci/hda/patch_conexant.c:1232:3: warning: statement with no effectSigned-off-by: Joe Perches
Signed-off-by: Takashi Iwai -
The auto-mute setup for Acer Aspire-one with ALC268 was set wrongly
during the clean-up of auto-mute function. Fixed now.Tested-by: Borislav Petkov
Signed-off-by: Takashi Iwai -
This patch adds the necessary details to support the PCIe version of
E-MU's 0404 card.
From comparing the PCBs it seems the PCIe version just added a PCIe
chipset and left all other components pretty much in place.
For anyone intrigued to take a look at the PCB there are pictures I took
at .Signed-off-by: Florian Zeitz
Signed-off-by: Takashi Iwai -
The PCI version of the RME HDSP MADI card uses 0xcf as revision ID. Just
add this to the list of supported cards.Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai