20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
14 Oct, 2014
1 commit
-
Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
compliant equivalent. This patch allocates the appropriate amount of memory
using a char array using the SHASH_DESC_ON_STACK macro.The new code can be compiled with both gcc and clang.
Signed-off-by: Jan-Simon Möller
Signed-off-by: Behan Webster
Reviewed-by: Mark Charlebois
Acked-by: Herbert Xu
24 Sep, 2014
1 commit
-
If the ccp is built as a built-in module, then ccp-crypto (whether
built as a module or a built-in module) will be able to load and
it will register its crypto algorithms. If the system does not have
a CCP this will result in -ENODEV being returned whenever a command
is attempted to be queued by the registered crypto algorithms.Add an API, ccp_present(), that checks for the presence of a CCP
on the system. The ccp-crypto module can use this to determine if it
should register it's crypto alogorithms.Cc: stable@vger.kernel.org
Reported-by: Scot Doyle
Signed-off-by: Tom Lendacky
Tested-by: Scot Doyle
Signed-off-by: Herbert Xu
13 Aug, 2014
1 commit
-
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines. This issue was reported by checkpatch.A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/)://
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;//
[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine
Signed-off-by: Bjorn Helgaas
01 Aug, 2014
1 commit
-
The CCP hardware interprets all numbers as unsigned numbers, therefore
sign extending input data is not valid. Modify the function calls
for RSA and ECC to not perform sign extending.This patch is based on the cryptodev-2.6 kernel tree.
Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu
24 Jul, 2014
1 commit
-
The addition of the "select OF if ARM64" has led to a Kconfig
recursive dependency error when "make ARCH=sh rsk7269_defconfig"
was run. Since OF is selected by ARM64 and the of_property_read_bool
is defined no matter what, delete the Kconfig line that selects OF.Reported-by: kbuild test robot
Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu
23 Jul, 2014
1 commit
-
The default cache operations for ARM64 were changed during 3.15.
To use coherent operations a "dma-coherent" device tree property
is required. If that property is not present in the device tree
node then the non-coherent operations are assigned for the device.Add support to the ccp driver to assign the AXI DMA cache settings
based on whether the "dma-coherent" property is present in the device
node. If present, use settings that work with the caches. If not
present, use settings that do not look at the caches.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu
20 Jun, 2014
2 commits
-
Add support for the CCP on arm64 as a platform device.
Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Modify the PCI device support in prep for supporting the
CCP as a platform device for arm64.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu
22 May, 2014
1 commit
-
Signed-off-by: Marek Vasut
Signed-off-by: Herbert Xu
16 Apr, 2014
1 commit
-
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.Signed-off-by: Alexander Gordeev
Cc: Tom Lendacky
Cc: "David S. Miller"
Cc: linux-crypto@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Signed-off-by: Herbert Xu
27 Feb, 2014
3 commits
-
When the crypto layer is able to queue up a command for processing
by the CCP on the initial call to ccp_crypto_enqueue_request and
the CCP returns -EBUSY, then if the backlog flag is not set the
command needs to be freed and not added to the active command list.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Invoke the callback routine associated with the crypto context
if an error is encountered sending the command to the CCP during
backlog processing. This is needed to free any resources used
by the command.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
If a CCP command has been queued for processing at the
crypto layer then, when dequeueing it for processing, the
"can backlog" flag must be set so that the request isn't
lost if the CCP backlog queue limit is reached.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu
09 Feb, 2014
5 commits
-
Change from scheduling work to scheduling a tasklet to perform
the callback operations.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Move to a single queue to serialize requests within a tfm. When
testing using IPSec with a large number of network connections
the per cpu tfm queuing logic was not working properly.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Move the support to perform an HMAC calculation into
the CCP operations file. This eliminates the need to
perform a synchronous SHA operation used to calculate
the HMAC.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Introduce module parameters that allow for disabling of a
crypto algorithm by not registering the algorithm with the
crypto API.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
There are some suspicious looking lines of code in the new ccp driver, including
one that assigns a variable to itself, and another that overwrites a previous assignment.This may have been a cut-and-paste error where 'src' was forgotten to be changed to 'dst'.
I have no hardware to test this, so this is untested.Signed-off-by: Dave Jones
Acked-by: Tom Lendacky
Signed-off-by: Herbert Xu
15 Jan, 2014
6 commits
-
The CCP cannot be hot-plugged so it will either be there
or it won't. Do not allow the driver to stay loaded if the
CCP does not successfully initialize.Provide stub routines in the ccp.h file that return -ENODEV
if the CCP has not been configured in the build.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Cleanup the ahash digest invocations to check the init
return code and make use of the finup routine.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
When performing a hash operation if the amount of data buffered and a
request at or near the maximum data length is received then the length
calcuation could wrap causing an error in executing the hash operation.
Fix this by using a u64 type for the input and output data lengths in
all CCP operations.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
For a hash operation, the caller doesn't have to supply a result
area on every call so don't use it / update it if it hasn't
been supplied.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Cleanup up the usage of scatterlists to make the code cleaner
and avoid extra memory allocations when not needed.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Fix some memory allocations to use the appropriate gfp_t type based
on the CRYPTO_TFM_REQ_MAY_SLEEP flag.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu
30 Dec, 2013
1 commit
-
Driver core sets it to NULL upon probe failure or release.
Signed-off-by: Sachin Kamat
Signed-off-by: Herbert Xu
20 Dec, 2013
3 commits
-
Remove the pr_err calls that are issued during parameter
checking in some AES operations. This will eliminate the
possibility of filling up syslog through these paths.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
Update the Kconfig to include PCI on the 'depends on'
and add 'select HW_RANDOM' to insure the necessary PCI
and HW_RANDOM functions are available/included in the
build.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
The sha initialization data generated the following sparse warnings:
sparse: incorrect type in initializer (different base types)
expected unsigned int
got restricted __be32 [usertype]Change the initialization data type from u32 to __be32.
Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu
09 Dec, 2013
1 commit
-
drivers/crypto/ccp/ccp-crypto-aes.c:344:1-7: Replace memcpy with struct assignment
drivers/crypto/ccp/ccp-crypto-sha.c:398:1-7: Replace memcpy with struct assignment
drivers/crypto/ccp/ccp-dev.c:578:2-3: Unneeded semicolon
/c/kernel-tests/src/cocci/drivers/crypto/ccp/ccp-dev.c:565:2-3: Unneeded semicolonGenerated by: coccinelle/misc/memcpy-assign.cocci
CC: Tom Lendacky
Signed-off-by: Fengguang Wu
Signed-off-by: Herbert Xu
05 Dec, 2013
7 commits
-
These files provide the ability to configure and build the
AMD CCP device driver and crypto API support.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
These routines provide crypto API support for SHA1, SHA224 and SHA256
on the AMD CCP. HMAC support for these SHA modes is also provided.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
These routines provide crypto API support for the XTS-AES mode of AES
on the AMD CCP.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
These routines provide crypto API support for the CMAC mode of AES
on the AMD CCP.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
These routines provide crypto API support for AES on the AMD CCP.
Support for AES modes: ECB, CBC, OFB, CFB and CTR
Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
These routines provide the support for the interface between the crypto API
and the AMD CCP. This includes insuring that requests associated with a
given tfm on the same cpu are processed in the order received.Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu -
These routines provide the device driver support for the AMD
Cryptographic Coprocessor (CCP).Signed-off-by: Tom Lendacky
Signed-off-by: Herbert Xu