26 Jul, 2014
2 commits
-
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//Signed-off-by: Peter Senna Tschudin
Acked-by: Sudarsana Kalluru
Signed-off-by: Christoph Hellwig -
Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
Signed-off-by: Joe Perches
Acked-by: Anil Gurumurthy
Signed-off-by: Christoph Hellwig
16 Mar, 2014
1 commit
-
Add the missing unlock before return from function bfad_iocmd_cfg_trunk()
in the error handling case.Signed-off-by: Wei Yongjun
Acked-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley
19 Dec, 2013
1 commit
-
This patch includes change to enable firmware patch simplication
feature. This feature is targeted to address the requirement to have
independent patch release for firmware. Prior to 3.2.3, releasing a
patch fix for firmware requires changes to bfa, to use new firmware
images. But with these changes, if the new firmware is flashed on to the
HBA with brocade adapter management utilites, driver uses the new
firmware after checking the patch release byte in the firmware version.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley
27 Jun, 2013
4 commits
-
1. While FRU VPD data update, inform firmware to send a completion event
on I2C bus. Without this change, firmware used to send completion
message on I2C bus for every chunk of FRU VPD update.
2. Support for FRU VPN update on CHINOOK2 cards.
3. Append port count to the model name to differentiate between single
port and dual port model of 1860.
4. Update the size of the model name to 16bytesSigned-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Replaced usage of void * with u64 in data structure shared between
brocade user space libraries and the bfa driver to address pointer
size changes across 32-bit vs 64-bit to have the compatibility between
32bit library and 64bit driver and vice versa.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
D-Port is a new port type created with the intention of running link
level diagnostic tests like loopback, traffic test. In static D-port
mode, user configures the port to D-port mode and starts the test, but
in dynamic D-port, once the Brocade switch port is configured to
D-port, it will reject the regular FLOGI from HBA with reason that it is
in D-port mode. So based on the reason code HBA port will turn itself into
D-port and start diagnostic test.Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
This patch includes changes to 1) Enable/disable fc credit recovery on
Brocade FC adapter port operating at max supported speed. 2) Get credit
recovery status and stats related to credit loss and recovered creditsSigned-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley
07 Oct, 2012
6 commits
-
- Add FRU sub-module to support FRU read/write/update.
- Add support to read/write from the temp FRU module.[jejb: fix checkpatch issues]
Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added support to configure minimum bandwidth for a pcifn.
- Minimum bandwith is guaranteed at per queue level.
- Added support to update pcifn bandwidth dynamically without
a server reboot.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
Add capability to limit the number of exchanges on a port to
avoid queue-full conditions from the target side.Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
Made changes to provide an option for user to configure the
bandwidth percentage for High/Medium/Low QoS priorities.Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Introduced support for D-Port which is a new port mode during which
link level diagnostics can be run.
- Provided mechanism to dynamically configure D-Port and initiate diagnostic
tests to isolate any link level issues.
- In D-Port mode, the HBA port does not participate in fabric or login to the
remote device or run data traffic.
- Diagnostic tests include running various loopback tests in conjunction with
the attached device.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Add private loop topology support at 2G/4G/8G speeds with following
limitations
1. No support for multiple initiators in the loop
2. No public loop support. If attached to a loop with an FL_Port,
device continues to work as a private NL_Port in the loop
3. No auto topology detection. User has to manually set the
configured topology to loop if attaching to loop.
- When loop topology is configured, enabling FC port features
QoS/Trunk/TRL are not allowed and vice versa.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley
24 Sep, 2012
3 commits
-
- Changes to avoid discovering NPIV port as remote port by the other
NPIV ports created on same physical port when all the NPIV ports are
part of the same zone in a fabric.
- Provided mechanism to support maximum number of target ports for a
given initiator port (physical port + NPIV ports) irrespective of the
way in which the initiator and target ports are zoned in the fabric.
- Introduced module_parameter max_rport_logins to restrict number of
remote ports discovery which includes target and initiator remote ports.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Made changes to split FCXP resources as request and response resources.
- The split will reduce the contention for FCXP resources in an open zone
config.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Introduced rport qualifier structure and modified design to
export remote ports with valid pid or valid pwwn to the user space.
- Introduced old_pid field in the rport structure and made changes to
prevent re-creating a new remote port for an already existing rport
that is transitioning to a delete state. (Happens if we receive a RSCN
on the existing remote port that is getting deleted).Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley
20 Jul, 2012
1 commit
-
- Remove unnecessary if NULL check in function bfa_fcs_vport_free().
- Set correct return error codes in case of memory allocation failure
in the BSG ELS/CT passthru command handler.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley
28 Mar, 2012
2 commits
-
Made changes to set the rport maxfrsize param to use a value that is
equal to or less than the Buffer-to-Buffer Receive Data_Field size
specified in the Common Service Parameters.
Increased the diag memtest timeout for the Brocade-1860 adapters.
Made changes to enable valid port speed configuration check for all adapters.
Made changes to increase the max hw segments in a request, in order to
support larger data transfers from user space.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
Made changes to the Fabric Assigned Address(FAA) feature implementation.
Introduced the IOCFC state machine, which now handles the FAA logic,
IOC and BFA sub-modules enablement.
Removed un-wanted FAA enable/disable routines; FAA is enabled by default.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley
27 Mar, 2012
1 commit
-
Casting pointer from native data type to other type is
endian-sensitive."iocmd->offset" is 64 bit but we use only first 32 bit.
It works in little-endian system but in big-endian system
it will break.Signed-off-by: Santosh Nayak
Acked-by: Jing Huang
Signed-off-by: James Bottomley
19 Feb, 2012
1 commit
-
If 'drv_fcxp = kzalloc(sizeof(struct bfad_fcxp), GFP_KERNEL);' fails
and returns NULL, then we'll leak the memory allocated to 'bsg_fcpt'
when we jump to 'out:' and the variable subsequently goes out of
scope.Also remove the cast of the kzalloc() return value. kzalloc() returns
a void* which is implicitly converted, so the explicit cast is
pointless.Signed-off-by: Jesper Juhl
Acked-by: Krishna Gudipati
Signed-off-by: James Bottomley
11 Jan, 2012
1 commit
-
This patch re-implements LUN Masking feature using SCSI Slave Callouts. With
the new design in the slave_alloc entry point; for each new LUN discovered we
check with our internal LUN Masking config whether to expose or to mask this
particular LUN. We return -ENXIO (No such device or address) from slave_alloc
for the LUNs we don't want to be exposed. We also notify the SCSI mid-layer
to do a sequential LUN scan rather than REPORT_LUNS based scan if LUN masking
is enabled on our HBA port, since a -ENXIO from any LUN in REPORT_LUNS based
scan translates to a scan abort. This patch also handles the dynamic lun
masking config change from enable to disable or vice-versa by resetting
sdev_bflags of LUN 0 appropriately.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley
27 Jul, 2011
10 commits
-
- Added support to enable / disable lunmasking on Brocade adapter ports.
- Added support to query / clear lunmasking configuration.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added support to configure QOS on Brocade adapter ports.
- Added support to collect / reset QOS statistics.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added logic to enable / disable trunking on Brocade adapter ports.
- Added logic to query trunking info.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added support to collect and reset fcport stats.
- Modified design to allow multiple requests for fcport stats.
- fcport will remember the stats request in its stats_pending
queue and service each of the queued requests after receiving
a firmware response for the prior request.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Made changes to support IO profiling.
- Added support to configure and query IO profiling info.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
Extended BSG to support stats, port log and trace reset and to support
adapter, port SET operations.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added support to post vendor unique events on fc_host.
- Supports adapter, port, ioc, flash and remote port based AEN events.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley
30 Jun, 2011
7 commits
-
- Added a new module parameter max_xfer_size to
set the max_sectors in the scsi_host template.
- Added logic to handle request_irq() failure so
that msix vector resource is de-allocated immediately
when failure happens.
- BSG enhancements to collect vHBA releated info and port log.
- Removed the workaround of incrementing the module refcnt on bsg request.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added PHY sub-module.
- Implemented interface to obtain stats and to
read/update the fw from the PHY module.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added diagnostics sub-module to BFA.
- Implemented interface to perform memtest/loopback test
and some other diagnostics tests.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added flash sub-module.
- Implemented the interface to read/erase/update flash partition.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added SFP sub-module to BFA.
- Added interface to collect sfp media info and sfp speed.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added CEE sub-module.
- Added support to collect stats/cee module info
using BSG interface.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley -
- Added support to collect driver/fw stats.
- Added support to perform adapter/ioc enable, disable operations.Signed-off-by: Krishna Gudipati
Signed-off-by: James Bottomley