22 Sep, 2014
9 commits
-
This patch fixes following minor cleanup:
- Order the include files in alphabetical order.
- Fix description of state_off in extcon_gpio.h
- Add a descrition for check_on_resume in extcon_gpio.hSigned-off-by: George Cherian
[Modify the name/description of patch to keep standary codiyg style by Chanwoo Choi]
Signed-off-by: Chanwoo Choi -
When it writes some value other than 0 to BTLDset and JIGset, muic device
will be reset automatically. And it happens during updating ADC debounce time,
because it shares same register. To update ADC debounce time without reset,
set value only to ADCDbset and 0 to BTLDset and JIGset.Signed-off-by: Jonghwa Lee
[Remove un-needed masking operation by Chanwoo Choi]
Signed-off-by: Chanwoo Choi -
Don't include when the driver does not use anything
from this header file.Signed-off-by: Jean Delvare
Acked-by: MyungJoo Ham
Signed-off-by: Chanwoo Choi
Cc: Chanwoo Choi
Cc: MyungJoo Ham -
Use resource managed interrupt line devm_request_threaded_irq() to
simplify a little cleanup paths:
- no goto to cleanup label,
- simpler remove function.Overall the driver size is decreased by 11 line of code.
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
This patch add support for Richtek RT8973A which is Micro USB Switch OVP
and i2c interface. The RT8973A is a USB port accessory detector and switch
that is optimized to protect low voltage system from abnormal high input
voltage (up to 28V) and supports high speed USB operation. Also, RT8973A
support 'auto-configuration' mode. If auto-configuration mode is enabled,
RT8973A would control internal h/w patch for USB D-/D+ switching.Signed-off-by: Chanwoo Choi
Signed-off-by: Seung-Woo Kim
Acked-by: Kyungmin Park -
This patch just clean up codes by using checkpatch script and fix warning
message about if statement.- the result of checkpatch script as following:
WARNING: void function return statements are not generally useful
+ return;
+}WARNING: quoted string split across lines
+ dev_err(info->dev, "failed: irq request (IRQ: %d,"
+ " error :%d)\n", muic_irq->irq, ret);- warning message about coding style.
drivers/extcon/extcon-sm5502.c:398 sm5502_muic_cable_handler()
warn: we tested 'attached' before and it was 'false'Signed-off-by: Chanwoo Choi
-
This patch move sm5502.h header file from 'include/linux/extcon' to
'driver/extcon' because sm5502.h is used for driver/extcon/extcon-sm5502.c.
and remove duplicate license description.Signed-off-by: Chanwoo Choi
-
This patch add I2C configuration dependency to fix following build break.
If specific kernel build I2C as module, extcon-sm5502 have to depend on
I2C configuration.drivers/built-in.o: In function `regmap_smbus_byte_reg_read':
regmap-i2c.c:(.text+0x5030a): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `regmap_smbus_byte_reg_write':
regmap-i2c.c:(.text+0x50338): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `regmap_smbus_word_reg_read':
regmap-i2c.c:(.text+0x50356): undefined reference to `i2c_smbus_read_word_data'
drivers/built-in.o: In function `regmap_smbus_word_reg_write':
regmap-i2c.c:(.text+0x50384): undefined reference to `i2c_smbus_write_word_data'
drivers/built-in.o: In function `regmap_i2c_read':
regmap-i2c.c:(.text+0x503cf): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `regmap_i2c_gather_write':
regmap-i2c.c:(.text+0x50442): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `regmap_i2c_write':
regmap-i2c.c:(.text+0x50474): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `sm5502_muic_i2c_init':
extcon-sm5502.c:(.init.text+0x6630): undefined reference to `i2c_register_driver'Signed-off-by: Chanwoo Choi
-
This patch fix bug when checking cable type. SM5502 have to use ADC value
to get correct cable type.Signed-off-by: Chanwoo Choi
23 Jul, 2014
6 commits
-
This patch changes internal hardware DP_CON/DM_CON switch according to
cable type. The SM5502 MUIC device can set hardware switch as following:
- OPEN (not connected state) / USB / UART / AUDIO
Also, this patch set VBUSIN switch according to cable type.Signed-off-by: Chanwoo Choi
-
This patch detect whether cable is connected or not and the cable type
after completing kernel/platform booting using system_power_efficient_wq.Signed-off-by: Chanwoo Choi
-
This patch add new SM5502 MUIC(Micro-USB Interface Controller) device by using
EXTCON subsystem. The extcon-sm5502 driver is capable of identifying the type
of the external power source and attached accessory. An external power sources,
such as Deticated Charger or a standard USB port, are able to charge the battery
in the smart phone via the connector.Signed-off-by: Chanwoo Choi
-
Previously we would do a regulator get against the main Arizona device
to obtain the MICVDD regulator. Arizona is an MFD device and normally
MICVDD will be supplied by one of its children (the arizona-micsupp
regulator). As devres destruction for the MFD device will run after all
its children have been destroyed, the regulator will be destroyed before
devres calls regulator_put. This causes a warning from both the
destruction of the child node, as the regulator is still open, and from
the put of the regulator as the regulator device has already been
destroyed.A simple fix here is to get the regulator against the extcon device
itself such that devres runs when the child is destroyed. This has the
additional benefit that if for some reason the extcon driver is unloaded
the regulator reference won't hang around until the MFD is unloaded.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. The following
checkpatch warning is also removed.WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Jingoo Han
[Acked by Charles Keepax for arizona part]
Acked-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
…nel/git/lee/mfd into extcon-next
Immutable branch between MFD, Extcon and Regulator due for v3.17
17 Jun, 2014
2 commits
-
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.Signed-off-by: Robert Baldyga
Reviewed-by: Krzysztof Kozlowski
Acked-by: Chanwoo Choi
Signed-off-by: Lee Jones -
This patch removes wrapper functions used to access regmap, and
make driver using regmap_*() functions instead.Signed-off-by: Robert Baldyga
Reviewed-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Acked-by: Chanwoo Choi
Signed-off-by: Lee Jones
16 Jun, 2014
8 commits
-
This patch set the parent device of extcon device using first parameter of
devm_extco_dev_allocate() to remove duplicate code on all of extcon provider
drivers.Signed-off-by: Chanwoo Choi
Reported-by: Charles Keepax
Tested-by: Charles Keepax
Cc: Charles Keepax
Cc: Mark Brown
Cc: Graeme Gregory
Cc: Kishon Vijay Abraham I
Cc: Krzysztof Kozlowski -
The higher levels of impedance have a higher minimum value than the
first level. As the same value was used for all levels, higher impedances
were reported with a very low level of accuracy. This patch applies the
approriate lower threshold for each level, whilst we are changing things
add a define for the maximum value at each level to improve readability.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
We can use the bypass mode on the MICVDD reg for button detection, as
the comment in the code states, however the code was mistakenly
disabling bypass. This patch corrects this and allows bypass mode during
button detection.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
Use extcon cable API instead of state API as it is much more
idiomatic.Signed-off-by: Nikesh Oswal
Signed-off-by: Charles Keepax
[Modify patch title by Chanwoo Choi]
Signed-off-by: Chanwoo Choi -
devm_input_allocate_device already sets the parent device to be that
passed to it, we also set this manually in arizona_extcon_probe. This
patch removes the redundant set from arizona_extcon_probe.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
This patch reorder the sequence of extcon device diver alphabetically
to imporbe readability.Signed-off-by: Chanwoo Choi
-
Array of struct of_device_id may be be const as expected by
of_match_table field.Signed-off-by: Krzysztof Kozlowski
Cc: Graeme Gregory
Signed-off-by: Chanwoo Choi -
Add config option for inverted jack detect switch that
opens when jack is inserted.Signed-off-by: Richard Fitzgerald
[Acked by Lee Jones for MFD part]
Acked-by: Lee Jones
Signed-off-by: Chanwoo Choi
29 Apr, 2014
9 commits
-
This patch use devm_extcon_dev_allocate() to simplify the memory control
of extcon device.Cc: Graeme Gregory
Cc: Kishon Vijay Abraham I
Cc: Felipe Balbi
Cc: Samuel Ortiz
Cc: Lee Jones
Signed-off-by: Chanwoo Choi
Acked-by: Lee Jones
Acked-by: Felipe Balbi
Tested-by: Felipe Balbi -
This patch use devm_extcon_dev_allocate() to simplify the memory control
of extcon device.Signed-off-by: Chanwoo Choi
Reviewed-by: Felipe Balbi -
This patch use devm_extcon_dev_allocate() to simplify the memory control
of extcon device.Signed-off-by: Chanwoo Choi
Reviewed-by: Felipe Balbi -
This patch use devm_extcon_dev_allocate() to simplify the memory control
of extcon device.Cc: Charles Keepax
Cc: Mark Brown
Cc: patches@opensource.wolfsonmicro.com
Signed-off-by: Chanwoo Choi
Acked-by: Charles Keepax
Reviewed-by: Felipe Balbi -
This patch use devm_extcon_dev_allocate() to simplify the memory control
of extcon device.Cc: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Felipe Balbi -
This patch use devm_extcon_dev_allocate() to simplify the memory control
of extcon device.Signed-off-by: Chanwoo Choi
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Felipe Balbi -
This patch use devm_extcon_dev_allocate() to simplify the memory control
of extcon device.Signed-off-by: Chanwoo Choi
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Felipe Balbi -
This patch add device managed devm_extcon_dev_{allocate,free} to automatically
free the memory of extcon_dev structure without handling free operation.Signed-off-by: Chanwoo Choi
Reviewed-by: Felipe Balbi -
This patch add APIs to control the extcon device on extcon provider driver.
The extcon_dev_allocate() allocates the memory of extcon device and initializes
supported cables. And then extcon_dev_free() decrement the reference of the
device of extcon device and free the memory of the extcon device. This APIs
must need to implement devm_extcon_dev_allocate()/free() APIs.Signed-off-by: Chanwoo Choi
Reviewed-by: Felipe Balbi
24 Apr, 2014
6 commits
-
Use the resource-managed extcon device register function (i.e.
devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device
is attached with this function, that extcon device is automatically unregistered
on driver detach. That reduces tiresome managing code.Signed-off-by: Sangjung Woo
Signed-off-by: Chanwoo Choi -
Use the resource-managed extcon device register function (i.e.
devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device
is attached with this function, that extcon device is automatically unregistered
on driver detach. That reduces tiresome managing code.Signed-off-by: Sangjung Woo
Signed-off-by: Chanwoo Choi -
Use the resource-managed extcon device register function (i.e.
devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device
is attached with this function, that extcon device is automatically unregistered
on driver detach. That reduces tiresome managing code.Signed-off-by: Sangjung Woo
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
Use the resource-managed extcon device register function (i.e.
devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device
is attached with this function, that extcon device is automatically unregistered
on driver detach. That reduces tiresome managing code.Signed-off-by: Sangjung Woo
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
Use the resource-managed extcon device register function (i.e.
devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device
is attached with this function, that extcon device is automatically unregistered
on driver detach. That reduces tiresome managing code.Signed-off-by: Sangjung Woo
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
Use the resource-managed extcon device register function (i.e.
devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device
is attached with this function, that extcon device is automatically unregistered
on driver detach. That reduces tiresome managing code.Signed-off-by: Sangjung Woo
Signed-off-by: Chanwoo Choi
