29 Jun, 2006
1 commit
-
Remove TTY_DONT_FLIP tty flag. This flag was introduced in 2.1.X kernels
to prevent the N_TTY line discipline functions read_chan() and
n_tty_receive_buf() from running at the same time. 2.2.15 introduced
tty->read_lock to protect access to the N_TTY read buffer, which is the
only state requiring protection between these two functions.The current TTY_DONT_FLIP implementation is broken for SMP, and is not
universally honored by drivers that send data directly to the line
discipline receive_buf function.Because TTY_DONT_FLIP is not necessary, is broken in implementation, and is
not universally honored, it is removed.Signed-off-by: Paul Fulghum
Cc: Alan Cox
Cc: Theodore Ts'o
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
28 Jun, 2006
1 commit
-
locking init cleanups:
- convert " = SPIN_LOCK_UNLOCKED" to spin_lock_init() or DEFINE_SPINLOCK()
- convert rwlocks in a similar mannerthis patch was generated automatically.
Motivation:
- cleanliness
- lockdep needs control of lock initialization, which the open-coded
variants do not give
- it's also useful for -rt and for lock debugging in generalSigned-off-by: Ingo Molnar
Signed-off-by: Arjan van de Ven
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
27 Jun, 2006
4 commits
-
* git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial:
typo fixes
Clean up 'inline is not at beginning' warnings for usb storage
Storage class should be first
i386: Trivial typo fixes
ixj: make ixj_set_tone_off() static
spelling fixes
fix paniced->panicked typos
Spelling fixes for Documentation/atomic_ops.txt
move acknowledgment for Mark Adler to CREDITS
remove the bouncing email address of David Campbell -
* master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6: (42 commits)
[IOAT]: Do not dereference THIS_MODULE directly to set unsafe.
[NETROM]: Fix possible null pointer dereference.
[NET] netpoll: break recursive loop in netpoll rx path
[NET] netpoll: don't spin forever sending to stopped queues
[IRDA]: add some IBM think pads
[ATM]: atm/mpc.c warning fix
[NET]: skb_find_text ignores to argument
[NET]: make net/core/dev.c:netdev_nit static
[NET]: Fix GSO problems in dev_hard_start_xmit()
[NET]: Fix CHECKSUM_HW GSO problems.
[TIPC]: Fix incorrect correction to discovery timer frequency computation.
[TIPC]: Get rid of dynamically allocated arrays in broadcast code.
[TIPC]: Fixed link switchover bugs
[TIPC]: Enhanced & cleaned up system messages; fixed 2 obscure memory leaks.
[TIPC]: First phase of assert() cleanup
[TIPC]: Disallow config operations that aren't supported in certain modes.
[TIPC]: Fixed memory leak in tipc_link_send() when destination is unreachable
[TIPC]: Added missing warning for out-of-memory condition
[TIPC]: Withdrawing all names from nameless port now returns success, not error
[TIPC]: Optimized argument validation done by connect().
... -
This patch converts the combination of list_del(A) and list_add(A, B) to
list_move(A, B) under net/rxrpc.Acked-by: David Howells
Signed-off-by: Akinobu Mita
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
acquired (aquired)
contiguous (contigious)
successful (succesful, succesfull)
surprise (suprise)
whether (weather)
some other misspellingsSigned-off-by: Andreas Mohr
Signed-off-by: Adrian Bunk
26 Jun, 2006
34 commits
-
If in nr_link_failed the neighbour list is non-empty but the node list
is empty we'll end dereferencing a in a NULL pointer.This fixes coverity 362.
Signed-off-by: Ralf Baechle
Signed-off-by: David S. Miller -
The netpoll system currently has a rx to tx path via:
netpoll_rx
__netpoll_rx
arp_reply
netpoll_send_skb
dev->hard_start_txThis rx->tx loop places network drivers at risk of inadvertently causing a
deadlock or BUG halt by recursively trying to acquire a spinlock that is
used in both their rx and tx paths (this problem was origionally reported
to me in the 3c59x driver, which shares a spinlock between the
boomerang_interrupt and boomerang_start_xmit routines).This patch breaks this loop, by queueing arp frames, so that they can be
responded to after all receive operations have been completed. Tested by
myself and the reported with successful results.Specifically it was tested with netdump. Heres the BZ with details:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194055Signed-off-by: Neil Horman
Acked-by: Matt Mackall
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
When transmitting a skb in netpoll_send_skb(), only retry a limited number
of times if the device queue is stopped.Signed-off-by: Jeremy Fitzhardinge
Acked-by: Matt Mackall
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
net/atm/mpc.c: In function 'MPOA_res_reply_rcvd':
net/atm/mpc.c:1116: warning: unused variable 'ip'Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
skb_find_text takes a "to" argument which is supposed to limit how
far into the skb it will search for the given text. At present,
it seems to ignore that argument on the first skb, and instead
return a match even if the text occurs beyond the limit.Patch below fixes this, after adjusting for the "from" starting
point. This consequently fixes the netfilter string match's "--to"
handling, which currently is broken.Signed-off-by: Phil Oester
Signed-off-by: David S. Miller -
netdev_nit can now become static.
Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
Fix 2 problems in dev_hard_start_xmit():
1. nskb->next needs to link back to skb->next if hard_start_xmit()
returns non-zero.2. Since the total number of GSO fragments may exceed MAX_SKB_FRAGS + 1,
it needs to stop transmitting if the netif_queue is stopped.Signed-off-by: Michael Chan
Acked-by: Herbert Xu
Signed-off-by: David S. Miller -
Fix checksum problems in the GSO code path for CHECKSUM_HW packets.
The ipv4 TCP pseudo header checksum has to be adjusted for GSO
segmented packets.The adjustment is needed because the length field in the pseudo-header
changes. However, because we have the inequality oldlen > newlen, we
know that delta = (u16)~oldlen + newlen is still a 16-bit quantity.
This also means that htonl(delta) + th->check still fits in 32 bits.
Therefore we don't have to use csum_add on this operations.This is based on a patch by Michael Chan .
Signed-off-by: Herbert Xu
Acked-by: Michael Chan
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
This change improves an earlier change which replaced the large local
variable arrays used during broadcasting with dynamically allocated arrays.
The temporary arrays are now incoprorated into the multicast link data
structure.Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Incorporates several related fixes:
- switchover now occurs when switching from an active link to a standby link
- failure of a standby link no longer initiates switchover
- links now display correct # of received packtes following reactivationSigned-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
This also contains enhancements to simplify comparisons in name table
publication removal algorithm and to simplify name table sanity checking
when shutting down TIPC.Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
This change provides user-friendly feedback when TIPC is unable to perform
certain configuration operations that don't work properly in certain modes.
(In particular, any reconfiguration request that would temporarily take TIPC
from network mode to standalone mode, or from standalone mode to not running
mode, is disallowed.)Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
This fix prevents a bearer from being enabled using the wrong interface.
For example, specifying "eth:eth14" might enable "eth:eth1" by mistake.Signed-off-by: Allan Stephens
Signed-off-by: Per Liden -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
This patch originated by Stephane Ouellette .
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
This fixes a bug spotted by the coverity checker, bug id #366. If
(mod(seqno - prev) != 1) we set buf to NULL, dereference it in the for
case, and set it to whatever value happes to be at adress 0+next, if it
happens to be non-zero, we even stay in the loop. It seems that the author
intended to break there.Signed-off-by: Eric Sesterhenn
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller -
This fix prevents node from crashing.
Signed-off-by: Allan Stephens
Signed-off-by: Per Liden
Signed-off-by: David S. Miller
