Eric Lee / smarc-ti-linux-kernel

23 Mar, 2010

1 commit

  • 1dcd81002   headerdep: perlcritic warning ... Browse Code »

    Minor perlcritic warning:
    headerdep.pl: "return" statement with explicit "undef" at line 84, column 2. See page 199 of PBP. (Severity: 5)

    The rationale according to PBP is that an explicit return of undef
    (contrary to most people's expectations) doesn't
    always evaluate as false. It has to with the fact that perl return value
    depends on context the function is called. If function is used in
    list context, the appropriate return value for false is an empty list;
    whereas in scalar context the return value for false is undefined.
    By just using a "return" both cases are handled.

    In the context of a trivial script this doesn't matter. But one script
    may be cut-paste into later code (most people like me only know 50%
    of perl), that is why perlcritic always complains

    Signed-off-by: Stephen Hemminger
    Signed-off-by: Michal Marek

    Stephen Hemminger
     

11 Mar, 2010

1 commit

10 Mar, 2010

1 commit

08 Mar, 2010

10 commits

  • e93bc1a0c   Revert "kbuild: specify absolute paths for cscope" ... Browse Code »

    This reverts commit eb8f844c0a41c4529a7d06b7801296eca9ae67aa. Ian
    Campbell writes:
    > I keep my kernel source tree on a more powerful build box where I run my
    > builds etc (including "make cscope") but run my editor from my
    > workstation with an NFS mount to the source. This worked fine for me
    > using relative paths for cscope. Using absolute paths in cscope breaks
    > this previously working setup because the root path is not the same on
    > both systems. I guess this is similar to moving the source tree around.
    >
    > Without wanting to start a flamewar it really sounds to me like we are
    > working around a vim (or cscope) bug here, emacs with cscope bindings
    > works fine in this configuration.

    Given that absolute paths can be forced by make O=. cscope, change the
    default back to relative paths.

    Ian Campbell
    Cc: Daniel Vetter
    Signed-off-by: Michal Marek

    Michal Marek
     
  • a6c366324   kbuild: Do not unnecessarily regenerate modules.builtin ... Browse Code »

    Only regenerate it if the configuration has changed. Also, do this after
    the modules build to fix errors with some weird Makefiles that are
    generated during build.

    Reported-by: Eric Miao
    Signed-off-by: Michal Marek

    Michal Marek
     
  • bae4cecc0   headers_install: use local file handles ... Browse Code »

    Better practice to use 3 arg open and local file handles.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • dbbe33e99   headers_check: fix perl warnings ... Browse Code »

    According to PBP; best way practice is to use local reference for file
    handle and three argument open. Also perl prototypes are a mistake.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 91416cfdf   export_report: fix perl warnings ... Browse Code »

    Use local file handles, use three argument open.
    Don't modify arguments in perl grep (use sed instead)

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 9c49fd307   profile2linkerlist: fix perl warnings ... Browse Code »

    Turn on strict checking.
    Simplify code by using "unless" statement.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 86d08e569   namespace: perlcritic warnings ... Browse Code »

    Use local file handle not global.
    Make loop and other variables local in scope.

    Signed-off-by: Stephen Hemminger
    Cc: Hui Zhu
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • a208868fc   checkversion: perl cleanup ... Browse Code »

    Turn on strict checking.
    Use three arguement open
    Standard practice in perl is to use undef not zero for false

    Signed-off-by: Stephen Hemminger
    Cc: Cong Wang
    Cc: Ralf Baechle
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 3da271573   checkincludes: fix perlcritic warnings ... Browse Code »

    Turn on strict checking.
    Use local file handles.
    Use three argument open.

    Signed-off-by: Stephen Hemminger
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • 1f2a144f5   scripts: improve checkstack ... Browse Code »

    Cleanup checkstack script:
    * Turn on strict checking
    * Fix resulting error message because the declaration syntax
    was incorrect.
    * Remove incorrect and misleading use of prototype
    - prototype not required for this type of sort function
    because $a and $b are being used in this contex
    - if prototype was being used it should be for both arguments
    * Use closure for sort function

    Signed-off-by: Stephen Hemminger
    Cc: Steven Rostedt
    Cc: Arjan van de Ven
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     

07 Mar, 2010

1 commit

03 Mar, 2010

25 commits

22 Feb, 2010

1 commit

  • a8bac511c   tags: Use $SRCARCH ... Browse Code »

    $ make mrproper
    $ make tags
    GEN tags
    find: `arch/x86_64/': No such file or directory

    Caused by commit f81b1be (tags: include headers before source files)

    Cc: Guennadi Liakhovetski
    Acked-by: WANG Cong
    Signed-off-by: Michal Marek

    Michal Marek