01 Aug, 2007

1 commit


10 Jul, 2007

1 commit


22 May, 2007

1 commit


12 May, 2007

2 commits

  • The intention of using port_mask in SFF init helpers was to eventually
    support exoctic configurations such as combination of legacy and
    native port on the same controller. This never became actually
    necessary and the related code always has been subtly broken one way
    or the other. Now that new init model is in place, there is no reason
    to make common helpers capable of handling all corner cases. Exotic
    cases can simply dealt within LLDs as necessary.

    This patch removes port_mask handling in SFF init helpers. SFF init
    helpers don't take n_ports argument and interpret it into port_mask
    anymore. All information is carried via port_info. n_ports argument
    is dropped and always two ports are allocated. LLD can tell SFF to
    skip certain port by marking it dummy. Note that SFF code has been
    treating unuvailable ports this way for a long time until recent
    breakage fix from Linus and is consistent with how other drivers
    handle with unavailable ports.

    This fixes 1-port legacy host handling still broken after the recent
    native mode fix and simplifies SFF init logic. The following changes
    are made...

    * ata_pci_init_native_host() and ata_init_legacy_host() both now try
    to initialized whatever they can and mark failed ports dummy. They
    return 0 if any port is successfully initialized.

    * ata_pci_prepare_native_host() and ata_pci_init_one() now doesn't
    take n_ports argument. All info should be specified via port_info
    array. Always two ports are allocated.

    * ata_pci_init_bmdma() exported to be used by LLDs in exotic cases.

    * port_info handling in all LLDs are standardized - all port_info
    arrays are const stack variable named ppi. Unless the second port
    is different from the first, its port_info is specified as NULL
    (tells libata that it's identical to the last non-NULL port_info).

    * pata_hpt37x/hpt3x2n: don't modify static variable directly. Make an
    on-stack copy instead as ata_piix does.

    * pata_uli: It has 4 ports instead of 2. Don't use
    ata_pci_prepare_native_host(). Allocate the host explicitly and use
    init helpers. It's simple enough.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     
  • Reimplement suspend/resume support using sdev->manage_start_stop.

    * Device suspend/resume is now SCSI layer's responsibility and the
    code is simplified a lot.

    * DPM is dropped. This also simplifies code a lot. Suspend/resume
    status is port-wide now.

    * ata_scsi_device_suspend/resume() and ata_dev_ready() removed.

    * Resume now has to wait for disk to spin up before proceeding. I
    couldn't find easy way out as libata is in EH waiting for the
    disk to be ready and sd is waiting for EH to complete to issue
    START_STOP.

    * sdev->manage_start_stop is set to 1 in ata_scsi_slave_config().
    This fixes spindown on shutdown and suspend-to-disk.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     

29 Apr, 2007

1 commit


03 Mar, 2007

2 commits


10 Feb, 2007

3 commits

  • This patch is against each libata driver.

    Two IRQ calls are added in ata_port_operations.
    - irq_on() is used to enable interrupts.
    - irq_ack() is used to acknowledge a device interrupt.

    In most drivers, ata_irq_on() and ata_irq_ack() are used for
    irq_on and irq_ack respectively.

    In some drivers (ex: ahci, sata_sil24) which cannot use them
    as is, ata_dummy_irq_on() and ata_dummy_irq_ack() are used.

    Signed-off-by: Kou Ishizaki
    Signed-off-by: Akira Iguchi
    Signed-off-by: Jeff Garzik

    Akira Iguchi
     
  • Convert libata core layer and LLDs to use iomap.

    * managed iomap is used. Pointer to pcim_iomap_table() is cached at
    host->iomap and used through out LLDs. This basically replaces
    host->mmio_base.

    * if possible, pcim_iomap_regions() is used

    Most iomap operation conversions are taken from Jeff Garzik
    's iomap branch.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     
  • Update libata LLDs to use devres. Core layer is already converted to
    support managed LLDs. This patch simplifies initialization and fixes
    many resource related bugs in init failure and detach path. For
    example, all converted drivers now handle ata_device_add() failure
    gracefully without excessive resource rollback code.

    As most resources are released automatically on driver detach, many
    drivers don't need or can do with much simpler ->{port|host}_stop().
    In general, stop callbacks are need iff port or host needs to be given
    commands to shut it down. Note that freezing is enough in many cases
    and ports are automatically frozen before being detached.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     

25 Jan, 2007

1 commit


03 Dec, 2006

1 commit


02 Dec, 2006

1 commit


29 Nov, 2006

1 commit


29 Sep, 2006

1 commit


27 Sep, 2006

1 commit


31 Aug, 2006

1 commit


30 Aug, 2006

1 commit