26 Oct, 2012
1 commit
-
This is a bugfix for a problem with the following symptoms:
1. A power cut happens
2. After reboot, we try to mount UBIFS
3. Mount fails with "No space left on device" error messageUBIFS complains like this:
UBIFS error (pid 28225): grab_empty_leb: could not find an empty LEB
The root cause of this problem is that when we mount, not all LEBs are
categorized. Only those which were read are. However, the
'ubifs_find_free_leb_for_idx()' function assumes that all LEBs were
categorized and 'c->freeable_cnt' is valid, which is a false assumption.This patch fixes the problem by teaching 'ubifs_find_free_leb_for_idx()'
to always fall back to LPT scanning if no freeable LEBs were found.This problem was reported by few people in the past, but Brent Taylor
was able to reproduce it and send me a flash image which cannot be mounted,
which made it easy to hunt the bug. Kudos to Brent.Reported-by: Brent Taylor
Signed-off-by: Artem Bityutskiy
Cc: stable@vger.kernel.org
18 Jun, 2012
1 commit
-
The asserts here never check anything because it uses '|' instead of
'&'. Now if the flags are not set it prints a warning a a stack trace.Signed-off-by: Dan Carpenter
Signed-off-by: Artem Bityutskiy
14 May, 2011
1 commit
-
This patch separates out all the budgeting-related information
from 'struct ubifs_info' to 'struct ubifs_budg_info'. This way the
code looks a bit cleaner. However, the main driver for this is
that we want to save budgeting information and print it later,
so a separate data structure for this is helpful.This patch is a preparation for the further debugging output
improvements.Signed-off-by: Artem Bityutskiy
08 Mar, 2009
1 commit
-
Make 'ubifs_find_free_space()' return offset where free space starts,
rather than the amount of free space. This is just more appropriat
for its caller.Signed-off-by: Artem Bityutskiy
30 Sep, 2008
1 commit
-
IS_ERR() macro already has unlikely(), so do not use constructions
like 'if (unlikely(IS_ERR())'.Signed-off-by: Hirofumi Nakagawa
Signed-off-by: Artem Bityutskiy
17 Sep, 2008
1 commit
-
The assert was not valid because one of the variables
'taken_empty_lebs' has transient values out of sync
with the other variables.Signed-off-by: Adrian Hunter
Signed-off-by: Artem Bityutskiy
31 Aug, 2008
2 commits
-
We add this component at other similar places, but not in this
one.Signed-off-by: Artem Bityutskiy
-
The assertion was incorrect, because it did not take into
account free space.This patch also amends the comments correspondingly, and
cleans them up a little.Signed-off-by: Artem Bityutskiy
13 Aug, 2008
2 commits
-
Signed-off-by: Adrian Hunter
-
At the moment UBIFS reserves twice old index size space for the
index. But this is not enough in some cases, because if the indexing
node are very fragmented and there are many small gaps, while the
dirty index has big znodes - in-the-gaps method would fail.Thus, reserve trise as more, in which case we are guaranteed that
we can commit in any case.Signed-off-by: Artem Bityutskiy
15 Jul, 2008
1 commit
-
This is a new flash file system. See
http://www.linux-mtd.infradead.org/doc/ubifs.htmlSigned-off-by: Artem Bityutskiy
Signed-off-by: Adrian Hunter