Eric Lee / smarc-ti-linux-kernel

17 Nov, 2014

1 commit

  • 52cff74ee   dcbnl : Disable software interrupts before taking dcb_lock ... Browse Code »

    Solves possible lockup issues that can be seen from firmware DCB agents calling
    into the DCB app api.

    DCB firmware event queues can be tied in with NAPI so that dcb events are
    generated in softIRQ context. This can results in calls to dcb_*app()
    functions which try to take the dcb_lock.

    If the the event triggers while we also have the dcb_lock because lldpad or
    some other agent happened to be issuing a get/set command we could see a cpu
    lockup.

    This code was not originally written with firmware agents in mind, hence
    grabbing dcb_lock from softIRQ context was not considered.

    Signed-off-by: Anish Bhatt
    Signed-off-by: David S. Miller

    Anish Bhatt
     

31 Jul, 2014

1 commit

  • 16eecd9be   dcbnl : Fix misleading dcb_app->priority explanation ... Browse Code »
    13

    Current explanation of dcb_app->priority is wrong. It says priority is
    expected to be a 3-bit unsigned integer which is only true when working with
    DCBx-IEEE. Use of dcb_app->priority by DCBx-CEE expects it to be 802.1p user
    priority bitmap. Updated accordingly

    This affects the cxgb4 driver, but I will post those changes as part of a
    larger changeset shortly.

    Fixes: 3e29027af4372 ("dcbnl: add support for ieee8021Qaz attributes")
    Signed-off-by: Anish Bhatt
    Acked-by: John Fastabend
    Signed-off-by: David S. Miller

    Anish Bhatt
     

18 Jul, 2014

1 commit

25 Apr, 2014

1 commit

  • 90f62cf30   net: Use netlink_ns_capable to verify the permisions of netlink messages ... Browse Code »
    5

    It is possible by passing a netlink socket to a more privileged
    executable and then to fool that executable into writing to the socket
    data that happens to be valid netlink message to do something that
    privileged executable did not intend to do.

    To keep this from happening replace bare capable and ns_capable calls
    with netlink_capable, netlink_net_calls and netlink_ns_capable calls.
    Which act the same as the previous calls except they verify that the
    opener of the socket had the desired permissions as well.

    Reported-by: Andy Lutomirski
    Signed-off-by: "Eric W. Biederman"
    Signed-off-by: David S. Miller

    Eric W. Biederman
     

15 Jan, 2014

1 commit

  • d9ac62be5   dcb: use __dev_get_by_name instead of dev_get_by_name to find interface ... Browse Code »

    The following call chain indicates that dcb_doit() is protected
    under rtnl_lock. So if we use __dev_get_by_name() instead of
    dev_get_by_name() to find interface handlers in it, this would
    help us avoid to change interface reference counter.

    rtnetlink_rcv()
    rtnl_lock()
    netlink_rcv_skb()
    dcb_doit()
    rtnl_unlock()

    Cc: John Fastabend
    Signed-off-by: Ying Xue
    Signed-off-by: David S. Miller

    Ying Xue
     

07 Dec, 2013

1 commit

  • c057b190b   net/*: Fix FSF address in file headers ... Browse Code »

    Several files refer to an old address for the Free Software Foundation
    in the file header comment. Resolve by replacing the address with
    the URL so that we do not have to keep
    updating the header comments anytime the address changes.

    CC: John Fastabend
    CC: Alex Duyck
    CC: Marcel Holtmann
    CC: Gustavo Padovan
    CC: Johan Hedberg
    CC: Jamal Hadi Salim
    Signed-off-by: Jeff Kirsher
    Signed-off-by: David S. Miller

    Jeff Kirsher
     

22 Mar, 2013

1 commit

12 Mar, 2013

1 commit

10 Mar, 2013

2 commits

  • 29cd8ae0e   dcbnl: fix various netlink info leaks ... Browse Code »

    The dcb netlink interface leaks stack memory in various places:
    * perm_addr[] buffer is only filled at max with 12 of the 32 bytes but
    copied completely,
    * no in-kernel driver fills all fields of an IEEE 802.1Qaz subcommand,
    so we're leaking up to 58 bytes for ieee_ets structs, up to 136 bytes
    for ieee_pfc structs, etc.,
    * the same is true for CEE -- no in-kernel driver fills the whole
    struct,

    Prevent all of the above stack info leaks by properly initializing the
    buffers/structures involved.

    Signed-off-by: Mathias Krause
    Signed-off-by: David S. Miller

    Mathias Krause
     
  • 23bdbc80e   dcb: fix sparse warnings ... Browse Code »

    Add header with function definitions to quiet warnings and avoid future errors.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    stephen hemminger
     

11 Dec, 2012

1 commit

  • 7c77ab24e   net: Allow DCBnl to use other namespaces besides init_net ... Browse Code »

    Allow DCB and net namespace to work together. This is useful if you
    have containers that are bound to 'phys' interfaces that want to
    also manage their DCB attributes.

    The net namespace is taken from sock_net(skb->sk) of the netlink skb.

    CC: "Eric W. Biederman"
    Signed-off-by: John Fastabend
    Signed-off-by: David S. Miller

    John Fastabend
     

19 Nov, 2012

1 commit

  • dfc47ef86   net: Push capable(CAP_NET_ADMIN) into the rtnl methods ... Browse Code »

    - In rtnetlink_rcv_msg convert the capable(CAP_NET_ADMIN) check
    to ns_capable(net->user-ns, CAP_NET_ADMIN). Allowing unprivileged
    users to make netlink calls to modify their local network
    namespace.

    - In the rtnetlink doit methods add capable(CAP_NET_ADMIN) so
    that calls that are not safe for unprivileged users are still
    protected.

    Later patches will remove the extra capable calls from methods
    that are safe for unprivilged users.

    Acked-by: Serge Hallyn
    Signed-off-by: "Eric W. Biederman"
    Signed-off-by: David S. Miller

    Eric W. Biederman
     

11 Sep, 2012

1 commit

  • 15e473046   netlink: Rename pid to portid to avoid confusion ... Browse Code »

    It is a frequent mistake to confuse the netlink port identifier with a
    process identifier. Try to reduce this confusion by renaming fields
    that hold port identifiers portid instead of pid.

    I have carefully avoided changing the structures exported to
    userspace to avoid changing the userspace API.

    I have successfully built an allyesconfig kernel with this change.

    Signed-off-by: "Eric W. Biederman"
    Acked-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Eric W. Biederman
     

11 Jul, 2012

1 commit

22 Jun, 2012

1 commit

  • bb1dfefdc   net: dcb: fix small regression in __dcbnl_pg_setcfg() ... Browse Code »

    A small regression was introduced in the reply command of
    dcbnl_pg_setcfg(). User space apps may be expecting the
    DCB_ATTR_PG_CFG attribute to be returned with the patch
    below TX or RX variants are returned.

    commit 7be994138b188387691322921c08e19bddf6d3c5
    Author: Thomas Graf
    Date: Wed Jun 13 02:54:55 2012 +0000

    dcbnl: Shorten all command handling functions

    This patch reverts this behavior and returns DCB_ATTR_PG_CFG

    Signed-off-by: John Fastabend
    Acked-by: Thomas Graf
    Signed-off-by: David S. Miller

    John Fastabend
     

14 Jun, 2012

10 commits

26 Apr, 2012

1 commit

  • 081579840   net: dcb: add CEE notify calls ... Browse Code »

    This adds code to trigger CEE events when an APP change or setall
    command is made from user space. This simplifies user space code
    significantly by creating a single interface to listen on that
    works with both firmware and userland agents.

    And if we end up with multiple agents this keeps every thing in
    sync userland agents, firmware agents, and kernel notifier consumers.

    For an example agent that listens for these events see:

    https://github.com/jrfastab/cgdcbxd

    cgdcbxd is a daemon used to monitor DCB netlink events and manage
    the net_prio control group sub-system.

    Signed-off-by: John Fastabend
    Acked-by: Shmulik Ravid
    Signed-off-by: David S. Miller

    John Fastabend
     

05 Apr, 2012

1 commit

  • 08f10affe   net/dcb: Add an optional max rate attribute ... Browse Code »

    Although not specified in 8021Qaz spec, it could be useful to enable drivers
    whose HW supports setting a rate limit for an ETS TC. This patch adds this
    optional attribute to DCB netlink. To use it, drivers should implement and
    register the callbacks ieee_setmaxrate and ieee_getmaxrate. The units are 64
    bits long and specified in Kbps to enable usage over both slow and very fast
    networks.

    Signed-off-by: Amir Vadai
    Signed-off-by: David S. Miller

    Amir Vadai
     

02 Apr, 2012

1 commit

01 Nov, 2011

2 commits

07 Oct, 2011

2 commits

09 Jul, 2011

1 commit

06 Jul, 2011

2 commits

  • 5b7f76267   dcbnl: Add CEE notification ... Browse Code »

    This patch add an unsolicited notification of the DCBX negotiated
    parameters for the CEE flavor of the DCBX protocol. The notification
    message is identical to the aggregated CEE get operation and holds all
    the pertinent local and peer information. The notification routine is
    exported so it can be invoked by drivers supporting an embedded DCBX
    stack.

    Signed-off-by: Shmulik Ravid
    Signed-off-by: David S. Miller

    Shmulik Ravid
     
  • 37cf4d1a9   dcbnl: Aggregated CEE GET operation ... Browse Code »

    The following couple of patches add dcbnl an unsolicited notification of
    the the DCB configuration for the CEE flavor of the DCBX protocol. This
    is useful when the user-mode DCB client is not responsible for
    conducting and resolving the DCBX negotiation (either because the DCBX
    stack is embedded in the HW or the negotiation is handled by another
    agent in the host), but still needs to get the negotiated parameters.
    This functionality already exists for the IEEE flavor of the DCBX
    protocol and these patches add it to the older CEE flavor.

    The first patch extends the CEE attribute GET operation to include not
    only the peer information, but also all the pertinent local
    configuration (negotiated parameters). The second patch adds and export
    a CEE specific notification routine.

    Signed-off-by: Shmulik Ravid
    Signed-off-by: David S. Miller

    Shmulik Ravid
     

23 Jun, 2011

1 commit

22 Jun, 2011

4 commits

  • 4003b6587   dcb: Add missing error check in dcb_ieee_set() ... Browse Code »

    Missing error checking before nla_parse_nested().

    Reported-by: Mark Rustad
    Signed-off-by: John Fastabend
    Signed-off-by: David S. Miller

    John Fastabend
     
  • ab6baf980   dcb: fix return type on dcb_setapp() ... Browse Code »

    Incorrect return type on dcb_setapp() this routine
    returns negative error codes. All call sites of
    dcb_setapp() assign the return value to an int already
    so no need to update drivers.

    Signed-off-by: John Fastabend
    Signed-off-by: David S. Miller

    John Fastabend
     
  • a364c8cf8   dcb: Add dcb_ieee_getapp_mask() for drivers to query APP settings ... Browse Code »

    With multiple APP entries per selector and protocol drivers
    or stacks may want to pick a specific value or stripe traffic
    across many priorities. Also if an APP entry in use is
    deleted the stack/driver may want to choose from the existing
    APP entries.

    To facilitate this and avoid having duplicate code to walk
    the APP ring provide a routine dcb_ieee_getapp_mask() to
    return a u8 bitmask of all priorities set for the specified
    selector and protocol. This routine and bitmask is a helper
    for DCB kernel users.

    Signed-off-by: John Fastabend
    Signed-off-by: David S. Miller

    John Fastabend
     
  • f9ae7e4b5   dcb: Add ieee_dcb_delapp() and dcb op to delete app entry ... Browse Code »

    Now that we allow multiple IEEE App entries we need a way
    to remove specific entries. To do this add the ieee_dcb_delapp()
    routine.

    Additionaly drivers may need to remove the APP entry from
    their firmware tables. Add dcb ops routine to handle this.

    Signed-off-by: John Fastabend
    Signed-off-by: David S. Miller

    John Fastabend