08 Jul, 2011

1 commit


27 Apr, 2011

1 commit

  • These warnings are exposed by gcc 4.6.
    net/mac80211/sta_info.c: In function 'sta_info_cleanup_expire_buffered':
    net/mac80211/sta_info.c:590:32: warning: variable 'sdata' set but not used
    net/mac80211/ibss.c: In function 'ieee80211_rx_mgmt_auth_ibss':
    net/mac80211/ibss.c:43:34: warning: variable 'status_code' set but not used
    net/mac80211/work.c: In function 'ieee80211_send_assoc':
    net/mac80211/work.c:203:9: warning: variable 'len' set but not used
    net/mac80211/tx.c: In function '__ieee80211_parse_tx_radiotap':
    net/mac80211/tx.c:1039:35: warning: variable 'sband' set but not used
    net/mac80211/mesh.c: In function 'ieee80211_mesh_rx_queued_mgmt':
    net/mac80211/mesh.c:616:28: warning: variable 'ifmsh' set but not used
    ...

    Signed-off-by: Rajkumar Manoharan
    Signed-off-by: John W. Linville

    Rajkumar Manoharan
     

16 Nov, 2010

1 commit

  • crypto_free_cipher() is a wrapper around crypto_free_tfm() which is a
    wrapper around crypto_destroy_tfm() and the latter can handle being passed
    a NULL pointer, so checking for NULL in the
    ieee80211_aes_key_free()/ieee80211_aes_cmac_key_free() wrappers around
    crypto_free_cipher() is pointless and just increase object code size
    needlesly and makes us execute extra test/branch instructions that we
    don't need.
    Btw; don't we have to many wrappers around wrappers ad nauseam here?
    Anyway, this patch removes the redundant conditionals.

    Signed-off-by: Jesper Juhl
    Signed-off-by: John W. Linville

    Jesper Juhl
     

17 Aug, 2010

1 commit

  • ieee80211_add_key() currently returns -ENOMEM in case of any error,
    including a missing crypto algorithm. Change ieee80211_key_alloc()
    and ieee80211_aes_{key_setup_encrypt,cmac_key_setup}() to encode
    errors with ERR_PTR() rather than returning NULL, and change
    ieee80211_add_key() accordingly.

    Compile-tested only.

    Reported-by: Marcin Owsiany
    Signed-off-by: Ben Hutchings
    Acked-by: Johannes Berg
    Signed-off-by: John W. Linville

    Ben Hutchings
     

09 Jul, 2008

2 commits


08 May, 2008

1 commit


09 Apr, 2008

1 commit


02 Nov, 2007

1 commit


11 Oct, 2007

1 commit

  • Hopefully captured all single statement cases under net/. I'm
    not too sure if there is some policy about #includes that are
    "guaranteed" (ie., in the current tree) to be available through
    some other #included header, so I just added linux/kernel.h to
    each changed file that didn't #include it previously.

    Signed-off-by: Ilpo Järvinen
    Signed-off-by: David S. Miller

    Ilpo Järvinen
     

06 May, 2007

1 commit